h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 18:23:04 +08:00
Code Issues Releases Wiki Activity

Merge pull request #27297 from EVAST9919/timeline-alloc

Browse Source 
Reduce allocations in `TimelineBlueprintContainer`
This commit is contained in:
Dean Herbert 2024-02-22 09:16:16 +08:00 committed by GitHub
commit d82b398752
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/Edit/Compose/Components/Timeline/TimelineBlueprintContainer.cs
View File

@ -116,6 +116,8 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
updateStacking(); updateStacking();
} }
private readonly Stack<HitObject> currentConcurrentObjects = new Stack<HitObject>();
private void updateStacking() private void updateStacking()
{ {
// because only blueprints of objects which are alive (via pooling) are displayed in the timeline, it's feasible to do this every-update. // because only blueprints of objects which are alive (via pooling) are displayed in the timeline, it's feasible to do this every-update.
@ -125,10 +127,12 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
// after the stack gets this tall, we can presume there is space underneath to draw subsequent blueprints. // after the stack gets this tall, we can presume there is space underneath to draw subsequent blueprints.
const int stack_reset_count = 3; const int stack_reset_count = 3;
Stack<HitObject> currentConcurrentObjects = new Stack<HitObject>(); currentConcurrentObjects.Clear();
foreach (var b in SelectionBlueprints.Reverse()) for (int i = SelectionBlueprints.Count - 1; i >= 0; i--)
{ {
var b = SelectionBlueprints[i];
// remove objects from the stack as long as their end time is in the past. // remove objects from the stack as long as their end time is in the past.
while (currentConcurrentObjects.TryPeek(out HitObject hitObject)) while (currentConcurrentObjects.TryPeek(out HitObject hitObject))
{ {