From 176a85763ce47d56132661b9a6a0feded98e7837 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Wed, 18 Jun 2025 17:59:54 +0200 Subject: [PATCH] Fix drawable hold notes continuing to show hit lighting with No Release mod and classic skin Closes https://github.com/ppy/osu/issues/33751. --- .../Objects/Drawables/DrawableHoldNote.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs index 6c607886ae..23c062164e 100644 --- a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs +++ b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs @@ -197,6 +197,11 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables public override void OnKilled() { base.OnKilled(); + // flush the final state of holding on kill. + // this matters because some skin implementations like legacy skin + // insert drawables in the hierarchy that are not a child of this DHO + // (see `LegacyBodyPiece` and related machinations with `lightContainer` being added at column level) + isHolding.Value = Result.IsHolding(Time.Current); (bodyPiece.Drawable as IHoldNoteBody)?.Recycle(); }