From d75e6f78d6bc6f6f549591da37974b547952105c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Tue, 25 Jul 2023 18:54:13 +0200 Subject: [PATCH] Adjust cyclic selection test to hitcircle lifetime adjustments As it turns out, the tightening of hitcircle lifetimes in editor caused the test to fail, since the objects were too far apart and at the starting time of the test, the first object was fully faded out and as such not alive, therefore leading cyclic selection to fail to select it. To fix, bring all three objects closer together time-wise so that this does not happen and the test can continue to exercise its original behaviour. --- osu.Game.Tests/Visual/Editing/TestSceneComposerSelection.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/osu.Game.Tests/Visual/Editing/TestSceneComposerSelection.cs b/osu.Game.Tests/Visual/Editing/TestSceneComposerSelection.cs index b1a7ef976a..3884a3108f 100644 --- a/osu.Game.Tests/Visual/Editing/TestSceneComposerSelection.cs +++ b/osu.Game.Tests/Visual/Editing/TestSceneComposerSelection.cs @@ -340,14 +340,14 @@ namespace osu.Game.Tests.Visual.Editing public void TestCyclicSelectionBackwards() { var firstObject = new HitCircle { Position = new Vector2(256, 192), StartTime = 0 }; - var secondObject = new HitCircle { Position = new Vector2(256, 192), StartTime = 300 }; - var thirdObject = new HitCircle { Position = new Vector2(256, 192), StartTime = 600 }; + var secondObject = new HitCircle { Position = new Vector2(256, 192), StartTime = 200 }; + var thirdObject = new HitCircle { Position = new Vector2(256, 192), StartTime = 400 }; AddStep("add hitobjects", () => EditorBeatmap.AddRange(new[] { firstObject, secondObject, thirdObject })); moveMouseToObject(() => firstObject); - AddStep("seek to third", () => EditorClock.Seek(600)); + AddStep("seek to third", () => EditorClock.Seek(350)); AddStep("left click", () => InputManager.Click(MouseButton.Left)); AddAssert("third selected", () => EditorBeatmap.SelectedHitObjects.Single(), () => Is.EqualTo(thirdObject));