h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 16:47:46 +08:00
Code Issues Releases Wiki Activity

Centralise INDEX_PATH to WikiOverlay

Browse Source
This commit is contained in:
Joseph Madamba 2024-01-08 14:24:56 -08:00
parent 58619f1684
commit d6ba7a9c6e
2 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Overlays/Wiki/WikiHeader.cs
View File

@ -17,8 +17,6 @@ namespace osu.Game.Overlays.Wiki
{
public partial class WikiHeader : BreadcrumbControlOverlayHeader
{
private const string index_path = "Main_page";
public static LocalisableString IndexPageString => LayoutStrings.HeaderHelpIndex;
public readonly Bindable<APIWikiPage> WikiPageData = new Bindable<APIWikiPage>();
@ -45,7 +43,7 @@ namespace osu.Game.Overlays.Wiki
TabControl.AddItem(IndexPageString);
if (e.NewValue.Path == index_path)
if (e.NewValue.Path == WikiOverlay.INDEX_PATH)
{
Current.Value = IndexPageString;
return;

10
osu.Game/Overlays/WikiOverlay.cs
View File

@ -19,11 +19,11 @@ namespace osu.Game.Overlays
{
public partial class WikiOverlay : OnlineOverlay<WikiHeader>
{
private const string index_path = "Main_page";
public const string INDEX_PATH = @"Main_page";
public string CurrentPath => path.Value;
private readonly Bindable<string> path = new Bindable<string>(index_path);
private readonly Bindable<string> path = new Bindable<string>(INDEX_PATH);
private readonly Bindable<APIWikiPage> wikiData = new Bindable<APIWikiPage>();
@ -43,7 +43,7 @@ namespace osu.Game.Overlays
{
}
public void ShowPage(string pagePath = index_path)
public void ShowPage(string pagePath = INDEX_PATH)
{
path.Value = pagePath.Trim('/');
Show();
@ -137,7 +137,7 @@ namespace osu.Game.Overlays
wikiData.Value = response;
path.Value = response.Path;
if (response.Layout == index_path.ToLowerInvariant())
if (response.Layout == INDEX_PATH.ToLowerInvariant())
{
LoadDisplay(new WikiMainPage
{
@ -161,7 +161,7 @@ namespace osu.Game.Overlays
path.Value = "error";
LoadDisplay(articlePage = new WikiArticlePage($@"{api.WebsiteRootUrl}/wiki/",
$"Something went wrong when trying to fetch page \"{originalPath}\".\n\n[Return to the main page](Main_page)."));
$"Something went wrong when trying to fetch page \"{originalPath}\".\n\n[Return to the main page]({INDEX_PATH})."));
}
private void showParentPage()