h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 07:07:45 +08:00
Code Issues Releases Wiki Activity

Always transfer updated counts once

Browse Source
This commit is contained in:
Dean Herbert 2024-09-19 19:23:14 +09:00
parent 8f49876fe7
commit d5c2484109
No known key found for this signature in database
1 changed files with 5 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCountController.cs
View File

@ -55,28 +55,13 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
scoreProcessor.OnResetFromReplayFrame += updateAllCounts; scoreProcessor.OnResetFromReplayFrame += updateAllCounts;
scoreProcessor.NewJudgement += judgement => updateCount(judgement, false); scoreProcessor.NewJudgement += judgement => updateCount(judgement, false);
scoreProcessor.JudgementReverted += judgement => updateCount(judgement, true); scoreProcessor.JudgementReverted += judgement => updateCount(judgement, true);
updateAllCounts();
} }
private bool hasUpdatedCounts;
private void updateAllCounts() private void updateAllCounts()
{ {
// This flow is made to handle cases of watching from the middle of a replay / spectating session. if (hasUpdatedCounts)
//
// Once we get an initial state, we can rely on `NewJudgement` and `JudgementReverted`, so
// as a preemptive optimisation, only do a full re-sync if we have all-zero counts.
bool hasCounts = false;
foreach (var r in results)
{
if (r.Value.ResultCount.Value > 0)
{
hasCounts = true;
break;
}
}
if (hasCounts)
return; return;
foreach (var kvp in scoreProcessor.Statistics) foreach (var kvp in scoreProcessor.Statistics)
@ -86,6 +71,8 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
count.ResultCount.Value = kvp.Value; count.ResultCount.Value = kvp.Value;
} }
hasUpdatedCounts = true;
} }
private void updateCount(JudgementResult judgement, bool revert) private void updateCount(JudgementResult judgement, bool revert)