From d570a6d308fe0aab0487ee13f62c540f3116da33 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Wed, 15 Feb 2017 12:38:10 +0900
Subject: [PATCH] Handle cases where HitObjects were not parsed.

---
 osu.Game/Screens/Play/Player.cs             | 17 +++++++++++++----
 osu.Game/Screens/Select/BeatmapInfoWedge.cs |  2 +-
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/osu.Game/Screens/Play/Player.cs b/osu.Game/Screens/Play/Player.cs
index 7f2fa415d2..650568f60b 100644
--- a/osu.Game/Screens/Play/Player.cs
+++ b/osu.Game/Screens/Play/Player.cs
@@ -23,6 +23,7 @@ using System.Linq;
 using osu.Game.Beatmaps;
 using OpenTK.Graphics;
 using osu.Framework.Graphics.Containers;
+using osu.Framework.Logging;
 
 namespace osu.Game.Screens.Play
 {
@@ -75,9 +76,14 @@ namespace osu.Game.Screens.Play
             {
                 if (Beatmap == null)
                     Beatmap = beatmaps.GetWorkingBeatmap(BeatmapInfo, withStoryboard: true);
+
+                if ((Beatmap?.Beatmap?.HitObjects.Count ?? 0) == 0)
+                    throw new Exception("No valid objects were found!");
             }
-            catch
+            catch (Exception e)
             {
+                Logger.Log($"Could not load this beatmap sucessfully ({e})!", LoggingTarget.Runtime, LogLevel.Error);
+
                 //couldn't load, hard abort!
                 Exit();
                 return;
@@ -117,7 +123,8 @@ namespace osu.Game.Screens.Play
             pauseOverlay = new PauseOverlay
             {
                 Depth = -1,
-                OnResume = delegate {
+                OnResume = delegate
+                {
                     Delay(400);
                     Schedule(Resume);
                 },
@@ -277,9 +284,9 @@ namespace osu.Game.Screens.Play
         protected override void OnEntering(GameMode last)
         {
             base.OnEntering(last);
-            
+
             (Background as BackgroundModeBeatmap)?.BlurTo(Vector2.Zero, 1000);
-            Background?.FadeTo((100f- dimLevel)/100, 1000);
+            Background?.FadeTo((100f - dimLevel) / 100, 1000);
 
             Content.Alpha = 0;
             dimLevel.ValueChanged += dimChanged;
@@ -287,6 +294,8 @@ namespace osu.Game.Screens.Play
 
         protected override bool OnExiting(GameMode next)
         {
+            if (pauseOverlay == null) return false;
+
             if (pauseOverlay.State != Visibility.Visible && !canPause) return true;
 
             if (!IsPaused && sourceClock.IsRunning) // For if the user presses escape quickly when entering the map
diff --git a/osu.Game/Screens/Select/BeatmapInfoWedge.cs b/osu.Game/Screens/Select/BeatmapInfoWedge.cs
index 390d175bd4..eb93b4ac1a 100644
--- a/osu.Game/Screens/Select/BeatmapInfoWedge.cs
+++ b/osu.Game/Screens/Select/BeatmapInfoWedge.cs
@@ -74,7 +74,7 @@ namespace osu.Game.Screens.Select
                 {
                     Name = "Length",
                     Icon = FontAwesome.fa_clock_o,
-                    Content = TimeSpan.FromMilliseconds(beatmap.Beatmap.HitObjects.Last().EndTime - beatmap.Beatmap.HitObjects.First().StartTime).ToString(@"m\:ss"),
+                    Content = beatmap.Beatmap.HitObjects.Count == 0 ? "-" : TimeSpan.FromMilliseconds(beatmap.Beatmap.HitObjects.Last().EndTime - beatmap.Beatmap.HitObjects.First().StartTime).ToString(@"m\:ss"),
                 }));
 
                 labels.Add(new InfoLabel(new BeatmapStatistic