mirror of
https://github.com/ppy/osu.git
synced 2024-09-21 16:47:29 +08:00
Add note about swells and their ticks
This commit is contained in:
parent
64b726d5ec
commit
d53996336c
@ -315,6 +315,9 @@ namespace osu.Game.Rulesets.Taiko.Tests
|
|||||||
hitObjectContainer.Add(drawableSwell);
|
hitObjectContainer.Add(drawableSwell);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// You might think that this should be a SwellTick since we're before the swell, but SwellTicks get no StartTime (ie. they are zero).
|
||||||
|
// This works fine in gameplay because they are judged whenever the user pressed, rather than being timed hits.
|
||||||
|
// But for sample playback purposes they can be ignored as noise.
|
||||||
AddAssert("most valid object is swell", () => triggerSource.GetMostValidObject(), Is.InstanceOf<Swell>);
|
AddAssert("most valid object is swell", () => triggerSource.GetMostValidObject(), Is.InstanceOf<Swell>);
|
||||||
checkSound(HitType.Centre, HitSampleInfo.HIT_NORMAL, SampleControlPoint.DEFAULT_BANK);
|
checkSound(HitType.Centre, HitSampleInfo.HIT_NORMAL, SampleControlPoint.DEFAULT_BANK);
|
||||||
checkSound(HitType.Rim, HitSampleInfo.HIT_CLAP, SampleControlPoint.DEFAULT_BANK);
|
checkSound(HitType.Rim, HitSampleInfo.HIT_CLAP, SampleControlPoint.DEFAULT_BANK);
|
||||||
@ -349,6 +352,9 @@ namespace osu.Game.Rulesets.Taiko.Tests
|
|||||||
hitObjectContainer.Add(drawableSwell);
|
hitObjectContainer.Add(drawableSwell);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// You might think that this should be a SwellTick since we're before the swell, but SwellTicks get no StartTime (ie. they are zero).
|
||||||
|
// This works fine in gameplay because they are judged whenever the user pressed, rather than being timed hits.
|
||||||
|
// But for sample playback purposes they can be ignored as noise.
|
||||||
AddAssert("most valid object is swell", () => triggerSource.GetMostValidObject(), Is.InstanceOf<Swell>);
|
AddAssert("most valid object is swell", () => triggerSource.GetMostValidObject(), Is.InstanceOf<Swell>);
|
||||||
checkSound(HitType.Centre, HitSampleInfo.HIT_NORMAL, "drum");
|
checkSound(HitType.Centre, HitSampleInfo.HIT_NORMAL, "drum");
|
||||||
checkSound(HitType.Rim, HitSampleInfo.HIT_CLAP, "drum");
|
checkSound(HitType.Rim, HitSampleInfo.HIT_CLAP, "drum");
|
||||||
|
Loading…
Reference in New Issue
Block a user