h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 10:18:22 +08:00
Code Issues Releases Wiki Activity

Improve messaging around failed scores

Browse Source
This commit is contained in:
Dean Herbert 2023-07-04 18:34:53 +09:00
parent 56bfb92ba6
commit d3eb06578e
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/BackgroundBeatmapProcessor.cs
View File

@ -216,6 +216,7 @@ namespace osu.Game
notificationOverlay?.Post(notification); notificationOverlay?.Post(notification);
int processedCount = 0; int processedCount = 0;
int failedCount = 0;
foreach (var id in scoreIds) foreach (var id in scoreIds)
{ {
@ -251,6 +252,7 @@ namespace osu.Game
catch (Exception e) catch (Exception e)
{ {
Logger.Log($"Failed to convert total score for {id}: {e}"); Logger.Log($"Failed to convert total score for {id}: {e}");
++failedCount;
} }
} }
@ -262,7 +264,12 @@ namespace osu.Game
} }
else else
{ {
notification.CompletionText = $"{processedCount} of {scoreIds.Count} score(s) have been upgraded to the new scoring algorithm. Check logs for issues with remaining scores."; notification.Text = $"{processedCount} of {scoreIds.Count} score(s) have been upgraded to the new scoring algorithm.";
// We may have arrived here due to user cancellation or completion with failures.
if (failedCount > 0)
notification.Text += $" Check logs for issues with {failedCount} failed upgrades.";
notification.State = ProgressNotificationState.Cancelled; notification.State = ProgressNotificationState.Cancelled;
} }
} }