From 7a8aabc402acc6ca16b8d7dafa2419be4354623d Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 17 Aug 2018 13:18:48 +0900 Subject: [PATCH 1/2] Fix notifications suggesting automatic reporting in non-deployed builds --- osu.Game/OsuGame.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/OsuGame.cs b/osu.Game/OsuGame.cs index ecf5500ca4..d54bdee1b2 100644 --- a/osu.Game/OsuGame.cs +++ b/osu.Game/OsuGame.cs @@ -463,7 +463,7 @@ namespace osu.Game Schedule(() => notifications.Post(new SimpleNotification { Icon = entry.Level == LogLevel.Important ? FontAwesome.fa_exclamation_circle : FontAwesome.fa_bomb, - Text = entry.Message + (entry.Exception != null ? "\n\nThis error has been automatically reported to the devs." : string.Empty), + Text = entry.Message + (entry.Exception != null && IsDeployedBuild ? "\n\nThis error has been automatically reported to the devs." : string.Empty), })); } else if (recentLogCount == short_term_display_limit) From 583e026906c46b5861bf30a3626dadc840fb5c13 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 17 Aug 2018 13:28:35 +0900 Subject: [PATCH 2/2] =?UTF-8?q?Don=E2=80=99t=20suppress=20unhandled=20exce?= =?UTF-8?q?ptions=20in=20debug=20builds?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- osu.Desktop/Program.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/osu.Desktop/Program.cs b/osu.Desktop/Program.cs index db77427f96..71613753bc 100644 --- a/osu.Desktop/Program.cs +++ b/osu.Desktop/Program.cs @@ -7,6 +7,7 @@ using System.Linq; using System.Threading; using System.Threading.Tasks; using osu.Framework; +using osu.Framework.Development; using osu.Framework.Logging; using osu.Framework.Platform; using osu.Game.IPC; @@ -51,7 +52,7 @@ namespace osu.Desktop } } - private static int allowableExceptions = 1; + private static int allowableExceptions = DebugUtils.IsDebugBuild ? 0 : 1; /// /// Allow a maximum of one unhandled exception, per second of execution.