From d07a724970672a2f847253b41363c53f86f37b85 Mon Sep 17 00:00:00 2001
From: smoogipoo <smoogipoo@smgi.me>
Date: Thu, 29 Nov 2018 17:18:59 +0900
Subject: [PATCH] Only allow replay screen changes in menu + songselect

---
 osu.Game/OsuGame.cs                   | 48 +++++++++++++++++++--------
 osu.Game/Screens/Menu/MainMenu.cs     |  2 ++
 osu.Game/Screens/OsuScreen.cs         |  2 ++
 osu.Game/Screens/Select/SongSelect.cs |  2 ++
 4 files changed, 40 insertions(+), 14 deletions(-)

diff --git a/osu.Game/OsuGame.cs b/osu.Game/OsuGame.cs
index 302509423f..26e587e5dd 100644
--- a/osu.Game/OsuGame.cs
+++ b/osu.Game/OsuGame.cs
@@ -260,13 +260,6 @@ namespace osu.Game
                 return;
             }
 
-            if (!menu.IsCurrentScreen)
-            {
-                menu.MakeCurrent();
-                this.Delay(500).Schedule(() => LoadScore(score), out scoreLoad);
-                return;
-            }
-
             var score = ScoreManager.GetScore(scoreInfo);
             if (score.Replay == null)
             {
@@ -274,19 +267,46 @@ namespace osu.Game
                 return;
             }
 
-            var databasedBeatmap = BeatmapManager.QueryBeatmap(b => b.ID == scoreInfo.BeatmapInfo.ID);
-            if (databasedBeatmap == null)
+            if (!currentScreen.AllowExternalScreenChange)
             {
-                Logger.Log("Tried to load a score for a beatmap we don't have!", LoggingTarget.Information);
+                notifications.Post(new SimpleNotification
+                {
+                    Text = $"Click here to watch {scoreInfo.User.Username} on {scoreInfo.BeatmapInfo}",
+                    Activated = () =>
+                    {
+                        loadScore();
+                        return true;
+                    }
+                });
+
                 return;
             }
 
-            ruleset.Value = score.Ruleset;
+            loadScore();
 
-            Beatmap.Value = BeatmapManager.GetWorkingBeatmap(databasedBeatmap);
-            Beatmap.Value.Mods.Value = score.Mods;
+            void loadScore()
+            {
+                if (!menu.IsCurrentScreen)
+                {
+                    menu.MakeCurrent();
+                    this.Delay(500).Schedule(loadScore, out scoreLoad);
+                    return;
+                }
 
-            menu.Push(new PlayerLoader(new ReplayPlayer(score)));
+                var databasedBeatmap = BeatmapManager.QueryBeatmap(b => b.ID == scoreInfo.BeatmapInfo.ID);
+                if (databasedBeatmap == null)
+                {
+                    Logger.Log("Tried to load a score for a beatmap we don't have!", LoggingTarget.Information);
+                    return;
+                }
+
+                ruleset.Value = score.Ruleset;
+
+                Beatmap.Value = BeatmapManager.GetWorkingBeatmap(databasedBeatmap);
+                Beatmap.Value.Mods.Value = score.Mods;
+
+                currentScreen.Push(new PlayerLoader(new ReplayPlayer(score)));
+            }
         }
 
         protected override void Dispose(bool isDisposing)
diff --git a/osu.Game/Screens/Menu/MainMenu.cs b/osu.Game/Screens/Menu/MainMenu.cs
index cafd718055..974e42dda0 100644
--- a/osu.Game/Screens/Menu/MainMenu.cs
+++ b/osu.Game/Screens/Menu/MainMenu.cs
@@ -29,6 +29,8 @@ namespace osu.Game.Screens.Menu
 
         protected override bool AllowBackButton => buttons.State != ButtonSystemState.Initial;
 
+        public override bool AllowExternalScreenChange => true;
+
         private readonly BackgroundScreenDefault background;
         private Screen songSelect;
 
diff --git a/osu.Game/Screens/OsuScreen.cs b/osu.Game/Screens/OsuScreen.cs
index 00309fbcd5..69f2b6ef9d 100644
--- a/osu.Game/Screens/OsuScreen.cs
+++ b/osu.Game/Screens/OsuScreen.cs
@@ -34,6 +34,8 @@ namespace osu.Game.Screens
 
         protected virtual bool AllowBackButton => true;
 
+        public virtual bool AllowExternalScreenChange => false;
+
         /// <summary>
         /// Override to create a BackgroundMode for the current screen.
         /// Note that the instance created may not be the used instance if it matches the BackgroundMode equality clause.
diff --git a/osu.Game/Screens/Select/SongSelect.cs b/osu.Game/Screens/Select/SongSelect.cs
index 360032c37c..b8458c4c70 100644
--- a/osu.Game/Screens/Select/SongSelect.cs
+++ b/osu.Game/Screens/Select/SongSelect.cs
@@ -40,6 +40,8 @@ namespace osu.Game.Screens.Select
 
         protected virtual bool ShowFooter => true;
 
+        public override bool AllowExternalScreenChange => true;
+
         /// <summary>
         /// Can be null if <see cref="ShowFooter"/> is false.
         /// </summary>