h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 19:42:55 +08:00
Code Issues Releases Wiki Activity

Add inline commentary in Mod{Day,Night}core about different speed adjustments

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-10-18 12:27:16 +02:00
parent 9907adc337
commit cff69d63a6
No known key found for this signature in database
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Rulesets/Mods/ModDaycore.cs
View File

@ -33,6 +33,8 @@ namespace osu.Game.Rulesets.Mods
{ {
rateAdjustHelper = new RateAdjustModHelper(SpeedChange); rateAdjustHelper = new RateAdjustModHelper(SpeedChange);
// intentionally not deferring the speed change handling to `RateAdjustModHelper`
// as the expected result of operation is not the same (daycore should preserve constant pitch).
SpeedChange.BindValueChanged(val => SpeedChange.BindValueChanged(val =>
{ {
freqAdjust.Value = SpeedChange.Default; freqAdjust.Value = SpeedChange.Default;

2
osu.Game/Rulesets/Mods/ModNightcore.cs
View File

@ -45,6 +45,8 @@ namespace osu.Game.Rulesets.Mods
{ {
rateAdjustHelper = new RateAdjustModHelper(SpeedChange); rateAdjustHelper = new RateAdjustModHelper(SpeedChange);
// intentionally not deferring the speed change handling to `RateAdjustModHelper`
// as the expected result of operation is not the same (nightcore should preserve constant pitch).
SpeedChange.BindValueChanged(val => SpeedChange.BindValueChanged(val =>
{ {
freqAdjust.Value = SpeedChange.Default; freqAdjust.Value = SpeedChange.Default;