h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 12:42:54 +08:00
Code Issues Releases Wiki Activity

Merge pull request #10925 from peppy/fix-multiple-playback-on-skin-change

Browse Source 
Fix skinnable sounds playing more than once on skin change
This commit is contained in:
Dan Balasescu 2020-12-07 18:45:19 +09:00 committed by GitHub
commit cdc7ef8c15
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Skinning/PoolableSkinnableSample.cs
View File

@ -102,7 +102,7 @@ namespace osu.Game.Skinning
sampleContainer.Add(Sample = new DrawableSample(ch) { Looping = Looping }); sampleContainer.Add(Sample = new DrawableSample(ch) { Looping = Looping });
// Start playback internally for the new sample if the previous one was playing beforehand. // Start playback internally for the new sample if the previous one was playing beforehand.
if (wasPlaying) if (wasPlaying && Looping)
Play(); Play();
} }

2
osu.Game/Skinning/SkinnableSound.cs
View File

@ -159,7 +159,7 @@ namespace osu.Game.Skinning
samplesContainer.Add(sample); samplesContainer.Add(sample);
} }
if (wasPlaying) if (wasPlaying && Looping)
Play(); Play();
} }