Merge pull request #10925 from peppy/fix-multiple-playback-on-skin-change

Fix skinnable sounds playing more than once on skin change

osu.Game/Skinning/PoolableSkinnableSample.cs

@@ -102,7 +102,7 @@ namespace osu.Game.Skinning
             sampleContainer.Add(Sample = new DrawableSample(ch) { Looping = Looping });
 
             // Start playback internally for the new sample if the previous one was playing beforehand.
-            if (wasPlaying)
+            if (wasPlaying && Looping)
                 Play();
         }
 

osu.Game/Skinning/SkinnableSound.cs

@@ -159,7 +159,7 @@ namespace osu.Game.Skinning
                 samplesContainer.Add(sample);
             }
 
-            if (wasPlaying)
+            if (wasPlaying && Looping)
                 Play();
         }