diff --git a/osu.Desktop.VisualTests/Tests/TestCaseDetails.cs b/osu.Desktop.VisualTests/Tests/TestCaseDetails.cs index 0335e80e3a..3bfc0b147b 100644 --- a/osu.Desktop.VisualTests/Tests/TestCaseDetails.cs +++ b/osu.Desktop.VisualTests/Tests/TestCaseDetails.cs @@ -7,14 +7,11 @@ using osu.Framework.Testing; using osu.Game.Database; using osu.Game.Screens.Select; using System; -using System.Collections.Generic; using System.Linq; -using System.Text; -using System.Threading.Tasks; namespace osu.Desktop.VisualTests.Tests { - class TestCaseDetails : TestCase + internal class TestCaseDetails : TestCase { private Details details; diff --git a/osu.Game/Screens/Select/BeatmapDetailArea.cs b/osu.Game/Screens/Select/BeatmapDetailArea.cs index 337ad04e7d..355b2958e7 100644 --- a/osu.Game/Screens/Select/BeatmapDetailArea.cs +++ b/osu.Game/Screens/Select/BeatmapDetailArea.cs @@ -1,7 +1,6 @@ // Copyright (c) 2007-2017 ppy Pty Ltd . // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE -using System; using osu.Framework.Allocation; using osu.Framework.Graphics; using osu.Framework.Graphics.Containers; diff --git a/osu.Game/Screens/Select/Details.cs b/osu.Game/Screens/Select/Details.cs index 9ea474020b..1145e13338 100644 --- a/osu.Game/Screens/Select/Details.cs +++ b/osu.Game/Screens/Select/Details.cs @@ -18,22 +18,22 @@ namespace osu.Game.Screens.Select { public class Details : Container { - private SpriteText description; - private SpriteText source; - private FillFlowContainer tags; + private readonly SpriteText description; + private readonly SpriteText source; + private readonly FillFlowContainer tags; - private DifficultyRow circleSize; - private DifficultyRow drainRate; - private DifficultyRow overallDifficulty; - private DifficultyRow approachRate; - private DifficultyRow stars; + private readonly DifficultyRow circleSize; + private readonly DifficultyRow drainRate; + private readonly DifficultyRow overallDifficulty; + private readonly DifficultyRow approachRate; + private readonly DifficultyRow stars; - private DetailsBar ratingsBar; - private SpriteText negativeRatings; - private SpriteText positiveRatings; - private FillFlowContainer ratingsGraph; + private readonly DetailsBar ratingsBar; + private readonly SpriteText negativeRatings; + private readonly SpriteText positiveRatings; + private readonly FillFlowContainer ratingsGraph; - private FillFlowContainer retryAndFailGraph; + private readonly FillFlowContainer retryAndFailGraph; private BeatmapInfo beatmap; public BeatmapInfo Beatmap @@ -390,9 +390,9 @@ namespace osu.Game.Screens.Select private class DifficultyRow : Container { - private SpriteText name; - private DetailsBar bar; - private SpriteText valueText; + private readonly SpriteText name; + private readonly DetailsBar bar; + private readonly SpriteText valueText; private float difficultyValue; public float Value @@ -485,8 +485,8 @@ namespace osu.Game.Screens.Select private class RetryAndFailBar : Container { - private DetailsBar retryBar; - private DetailsBar failBar; + private readonly DetailsBar retryBar; + private readonly DetailsBar failBar; public float RetryLength { diff --git a/osu.Game/Screens/Select/DetailsBar.cs b/osu.Game/Screens/Select/DetailsBar.cs index b48b618fad..a7193cb822 100644 --- a/osu.Game/Screens/Select/DetailsBar.cs +++ b/osu.Game/Screens/Select/DetailsBar.cs @@ -6,14 +6,13 @@ using osu.Framework.Graphics; using osu.Framework.Graphics.Colour; using osu.Framework.Graphics.Containers; using osu.Framework.Graphics.Sprites; -using osu.Framework.Graphics.Transforms; namespace osu.Game.Screens.Select { public class DetailsBar : Container { - private Box background; - private Box bar; + private readonly Box background; + private readonly Box bar; private const int resize_duration = 250;