h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 10:42:54 +08:00
Code Issues Releases Wiki Activity

Add more checks and remove direct cast

Browse Source
This commit is contained in:
Dean Herbert 2017-08-24 20:31:57 +09:00
parent a7e6efd34f
commit c9f90efb8a
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Rulesets/UI/RulesetContainer.cs
View File

@ -42,7 +42,7 @@ namespace osu.Game.Rulesets.UI
/// <summary> /// <summary>
/// The input manager for this RulesetContainer. /// The input manager for this RulesetContainer.
/// </summary> /// </summary>
internal IHasReplayHandler ReplayInputManager => (IHasReplayHandler)KeyBindingInputManager; internal IHasReplayHandler ReplayInputManager => KeyBindingInputManager as IHasReplayHandler;
/// <summary> /// <summary>
/// The key conversion input manager for this RulesetContainer. /// The key conversion input manager for this RulesetContainer.
@ -57,7 +57,7 @@ namespace osu.Game.Rulesets.UI
/// <summary> /// <summary>
/// Whether we have a replay loaded currently. /// Whether we have a replay loaded currently.
/// </summary> /// </summary>
public bool HasReplayLoaded => ReplayInputManager.ReplayInputHandler != null; public bool HasReplayLoaded => ReplayInputManager?.ReplayInputHandler != null;
public abstract IEnumerable<HitObject> Objects { get; } public abstract IEnumerable<HitObject> Objects { get; }
@ -107,6 +107,9 @@ namespace osu.Game.Rulesets.UI
/// <param name="replay">The replay, null for local input.</param> /// <param name="replay">The replay, null for local input.</param>
public virtual void SetReplay(Replay replay) public virtual void SetReplay(Replay replay)
{ {
if (ReplayInputManager == null)
throw new InvalidOperationException($"A {nameof(KeyBindingInputManager)} which supports replay loading is not available");
Replay = replay; Replay = replay;
ReplayInputManager.ReplayInputHandler = replay != null ? CreateReplayInputHandler(replay) : null; ReplayInputManager.ReplayInputHandler = replay != null ? CreateReplayInputHandler(replay) : null;
} }