Adjust namespaces.

Also adds transition, uses IHasCurrentValue, combines Mod TestCases and more.

osu.Desktop.VisualTests/Tests/TestCaseIngameModsContainer.cs

@@ -1,31 +0,0 @@
-// Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
-// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
-
-using OpenTK;
-using osu.Framework.Graphics;
-using osu.Game.Screens.Play;
-
-namespace osu.Desktop.VisualTests.Tests
-{
-    internal class TestCaseIngameModsContainer : TestCaseModSelectOverlay
-    {
-        public override string Description => @"Ingame mods visualization";
-
-        private ModsContainer modsContainer;
-
-        public override void Reset()
-        {
-            base.Reset();
-
-            Add(modsContainer = new ModsContainer
-            {
-                Anchor = Anchor.TopRight,
-                Origin = Anchor.TopRight,
-                AutoSizeAxes = Axes.Both,
-                Position = new Vector2(0, 25),
-            });
-
-            modsContainer.Mods.BindTo(ModSelect.SelectedMods);
-        }
-    }
-}

osu.Desktop.VisualTests/Tests/TestCaseMods.cs

@@ -6,16 +6,21 @@ using osu.Framework.Graphics;
 using osu.Game.Overlays.Mods;
 using osu.Framework.Testing;
 using osu.Game.Database;
+using osu.Game.Screens.Play.HUD;
+using OpenTK;
 
 namespace osu.Desktop.VisualTests.Tests
 {
-    internal class TestCaseModSelectOverlay : TestCase
+    internal class TestCaseMods : TestCase
     {
-        public override string Description => @"Tests the mod select overlay";
+        public override string Description => @"Mod select overlay and in-game display";
+
+        private ModSelectOverlay modSelect;
+        private ModDisplay modDisplay;
 
-        protected ModSelectOverlay ModSelect;
         private RulesetDatabase rulesets;
 
+
         [BackgroundDependencyLoader]
         private void load(RulesetDatabase rulesets)
         {
@@ -26,17 +31,27 @@ namespace osu.Desktop.VisualTests.Tests
         {
             base.Reset();
 
-            Add(ModSelect = new ModSelectOverlay
+            Add(modSelect = new ModSelectOverlay
             {
                 RelativeSizeAxes = Axes.X,
                 Origin = Anchor.BottomCentre,
                 Anchor = Anchor.BottomCentre,
             });
 
-            AddStep("Toggle", ModSelect.ToggleVisibility);
+            Add(modDisplay = new ModDisplay
+            {
+                Anchor = Anchor.TopRight,
+                Origin = Anchor.TopRight,
+                AutoSizeAxes = Axes.Both,
+                Position = new Vector2(0, 25),
+            });
+
+            modDisplay.Current.BindTo(modSelect.SelectedMods);
+
+            AddStep("Toggle", modSelect.ToggleVisibility);
 
             foreach (var ruleset in rulesets.AllRulesets)
-                AddStep(ruleset.CreateInstance().Description, () => ModSelect.Ruleset.Value = ruleset);
+                AddStep(ruleset.CreateInstance().Description, () => modSelect.Ruleset.Value = ruleset);
         }
     }
 }

osu.Desktop.VisualTests/Tests/TestCaseScoreCounter.cs

@@ -8,7 +8,7 @@ using osu.Framework.Graphics.Sprites;
 using osu.Framework.MathUtils;
 using osu.Framework.Testing;
 using osu.Game.Graphics.UserInterface;
-using osu.Game.Rulesets.UI;
+using osu.Game.Screens.Play.HUD;
 
 namespace osu.Desktop.VisualTests.Tests
 {

osu.Desktop.VisualTests/osu.Desktop.VisualTests.csproj

@@ -190,7 +190,6 @@
     <Compile Include="Tests\TestCaseDrawings.cs" />
     <Compile Include="Tests\TestCaseGamefield.cs" />
     <Compile Include="Tests\TestCaseGraph.cs" />
-    <Compile Include="Tests\TestCaseIngameModsContainer.cs" />
     <Compile Include="Tests\TestCaseManiaPlayfield.cs" />
     <Compile Include="Tests\TestCaseMenuOverlays.cs" />
     <Compile Include="Tests\TestCaseMusicController.cs" />
@@ -213,7 +212,7 @@
     <Compile Include="Platform\TestStorage.cs" />
     <Compile Include="Tests\TestCaseOptions.cs" />
     <Compile Include="Tests\TestCaseSongProgress.cs" />
-    <Compile Include="Tests\TestCaseModSelectOverlay.cs" />
+    <Compile Include="Tests\TestCaseMods.cs" />
     <Compile Include="Tests\TestCaseDialogOverlay.cs" />
     <Compile Include="Tests\TestCaseBeatmapOptionsOverlay.cs" />
     <Compile Include="Tests\TestCaseLeaderboard.cs" />

osu.Game/Screens/Play/HUD/ComboCounter.cs

@@ -10,7 +10,7 @@ using osu.Framework.Graphics.Transforms;
 using osu.Framework.MathUtils;
 using osu.Game.Graphics.Sprites;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play.HUD
 {
     public abstract class ComboCounter : Container
     {

osu.Game/Screens/Play/HUD/ComboResultCounter.cs

@@ -1,13 +1,13 @@
 // Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
 // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
 
+using System;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Transforms;
 using osu.Framework.MathUtils;
 using osu.Game.Graphics.UserInterface;
-using System;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play.HUD
 {
     /// <summary>
     /// Used to display combo with a roll-up animation in results screen.

osu.Game/Screens/Play/HUD/HealthDisplay.cs

@@ -4,7 +4,7 @@
 using osu.Framework.Configuration;
 using osu.Framework.Graphics.Containers;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play.HUD
 {
     public abstract class HealthDisplay : Container
     {

osu.Game/Screens/Play/HUD/ModDisplay.cs

@@ -0,0 +1,105 @@
+// Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
+// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
+
+using System.Collections.Generic;
+using System.Linq;
+using osu.Framework.Configuration;
+using osu.Framework.Graphics;
+using osu.Framework.Graphics.Containers;
+using osu.Framework.Graphics.Primitives;
+using osu.Framework.Graphics.UserInterface;
+using osu.Game.Graphics.Sprites;
+using osu.Game.Rulesets.Mods;
+using osu.Game.Rulesets.UI;
+using OpenTK;
+
+namespace osu.Game.Screens.Play.HUD
+{
+    public class ModDisplay : Container, IHasCurrentValue<IEnumerable<Mod>>
+    {
+        private readonly Bindable<IEnumerable<Mod>> mods = new Bindable<IEnumerable<Mod>>();
+
+        private bool showMods;
+        public bool ShowMods
+        {
+            get
+            {
+                return showMods;
+            }
+            set
+            {
+                showMods = value;
+                if (!showMods)
+                    Hide();
+                else
+                    Show();
+            }
+        }
+
+        public Bindable<IEnumerable<Mod>> Current => mods;
+
+        private readonly FillFlowContainer<ModIcon> iconsContainer;
+
+        public ModDisplay()
+        {
+            Children = new Drawable[]
+            {
+                iconsContainer = new IconFlow
+                {
+                    Anchor = Anchor.TopCentre,
+                    Origin = Anchor.TopCentre,
+                    AutoSizeAxes = Axes.Both,
+                    Direction = FillDirection.Horizontal,
+                    Margin = new MarginPadding { Left = 10, Right = 10 },
+                },
+                new OsuSpriteText
+                {
+                    Anchor = Anchor.BottomCentre,
+                    Origin = Anchor.TopCentre,
+                    Text = @"/ UNRANKED /",
+                    Font = @"Venera",
+                    TextSize = 12,
+                }
+            };
+
+            mods.ValueChanged += mods =>
+            {
+                iconsContainer.Clear();
+                foreach (Mod mod in mods)
+                {
+                    iconsContainer.Add(new ModIcon(mod)
+                    {
+                        AutoSizeAxes = Axes.Both,
+                        Scale = new Vector2(0.6f),
+                        
+                    });
+                }
+
+                if (IsLoaded)
+                    appearTransform();
+            };
+        }
+
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
+            appearTransform();
+        }
+
+        private void appearTransform()
+        {
+            iconsContainer.Flush();
+            iconsContainer.FadeInFromZero(1000, EasingTypes.OutQuint);
+            iconsContainer.TransformSpacingTo(new Vector2(5, 0));
+            using (iconsContainer.BeginDelayedSequence(1200))
+                iconsContainer.TransformSpacingTo(new Vector2(-25, 0), 500, EasingTypes.OutQuint);
+        }
+
+        private class IconFlow : FillFlowContainer<ModIcon>
+        {
+            // just reverses the depth of flow contents.
+            protected override IComparer<Drawable> DepthComparer => new ReverseCreationOrderDepthComparer();
+            protected override IEnumerable<ModIcon> FlowingChildren => base.FlowingChildren.Reverse();
+        }
+    }
+}

osu.Game/Screens/Play/HUD/StandardComboCounter.cs

@@ -3,7 +3,7 @@
 
 using OpenTK;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play.HUD
 {
     /// <summary>
     /// Uses the 'x' symbol and has a pop-out effect while rolling over.

osu.Game/Screens/Play/HUD/StandardHealthDisplay.cs

@@ -1,8 +1,7 @@
 // Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
 // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
 
-using OpenTK;
+using System;
-using OpenTK.Graphics;
 using osu.Framework.Extensions.Color4Extensions;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
@@ -10,9 +9,10 @@ using osu.Framework.Graphics.Sprites;
 using osu.Game.Graphics;
 using osu.Game.Rulesets.Judgements;
 using osu.Game.Rulesets.Objects.Drawables;
-using System;
+using OpenTK;
+using OpenTK.Graphics;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play.HUD
 {
     public class StandardHealthDisplay : HealthDisplay, IHasAccentColour
     {

osu.Game/Screens/Play/HUDOverlay.cs

@@ -5,18 +5,19 @@ using osu.Framework.Allocation;
 using osu.Framework.Configuration;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
+using osu.Framework.Input;
 using osu.Game.Configuration;
 using osu.Game.Graphics.UserInterface;
-using osu.Game.Screens.Play;
-using osu.Game.Rulesets.Scoring;
-using osu.Framework.Input;
-using OpenTK.Input;
 using osu.Game.Overlays;
 using osu.Game.Overlays.Notifications;
+using osu.Game.Rulesets.Scoring;
+using osu.Game.Rulesets.UI;
+using osu.Game.Screens.Play.HUD;
+using OpenTK.Input;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play
 {
-    public abstract class HudOverlay : Container
+    public abstract class HUDOverlay : Container
     {
         private const int duration = 100;
 
@@ -27,7 +28,7 @@ namespace osu.Game.Rulesets.UI
         public readonly RollingCounter<double> AccuracyCounter;
         public readonly HealthDisplay HealthDisplay;
         public readonly SongProgress Progress;
-        public readonly ModsContainer ModsContainer;
+        public readonly ModDisplay ModDisplay;
 
         private Bindable<bool> showKeyCounter;
         private Bindable<bool> showHud;
@@ -40,9 +41,9 @@ namespace osu.Game.Rulesets.UI
         protected abstract ScoreCounter CreateScoreCounter();
         protected abstract HealthDisplay CreateHealthDisplay();
         protected abstract SongProgress CreateProgress();
-        protected abstract ModsContainer CreateModsContainer();
+        protected abstract ModDisplay CreateModsContainer();
 
-        protected HudOverlay()
+        protected HUDOverlay()
         {
             RelativeSizeAxes = Axes.Both;
 
@@ -58,7 +59,7 @@ namespace osu.Game.Rulesets.UI
                     AccuracyCounter = CreateAccuracyCounter(),
                     HealthDisplay = CreateHealthDisplay(),
                     Progress = CreateProgress(),
-                    ModsContainer = CreateModsContainer(),
+                    ModDisplay = CreateModsContainer(),
                 }
             });
         }

osu.Game/Screens/Play/ModsContainer.cs

@@ -1,74 +0,0 @@
-// Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
-// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
-
-using osu.Framework.Graphics.Containers;
-using osu.Game.Rulesets.Mods;
-using osu.Game.Rulesets.UI;
-using osu.Framework.Graphics;
-using osu.Game.Graphics.Sprites;
-using OpenTK;
-using System.Collections.Generic;
-using osu.Framework.Configuration;
-
-namespace osu.Game.Screens.Play
-{
-    public class ModsContainer : Container
-    {
-        public readonly Bindable<IEnumerable<Mod>> Mods = new Bindable<IEnumerable<Mod>>();
-
-        private bool showMods;
-        public bool ShowMods
-        {
-            get
-            {
-                return showMods;
-            }
-            set
-            {
-                showMods = value;
-                if (!showMods)
-                    Hide();
-                else
-                    Show();
-            }
-        }
-
-        public ModsContainer()
-        {
-            FillFlowContainer<ModIcon> iconsContainer;
-
-            Children = new Drawable[]
-            {
-                iconsContainer = new FillFlowContainer<ModIcon>
-                {
-                    Anchor = Anchor.TopCentre,
-                    Origin = Anchor.TopCentre,
-                    AutoSizeAxes = Axes.Both,
-                    Direction = FillDirection.Horizontal,
-                    Spacing = new Vector2(5,0),
-                },
-                new OsuSpriteText
-                {
-                    Anchor = Anchor.BottomCentre,
-                    Origin = Anchor.TopCentre,
-                    Text = @"/ UNRANKED /",
-                    Font = @"Venera",
-                    TextSize = 12,
-                }
-            };
-
-            Mods.ValueChanged += mods =>
-            {
-                iconsContainer.Clear();
-                foreach (Mod mod in mods)
-                {
-                    iconsContainer.Add(new ModIcon(mod)
-                    {
-                        AutoSizeAxes = Axes.Both,
-                        Scale = new Vector2(0.65f),
-                    });
-                }
-            };
-        }
-    }
-}

osu.Game/Screens/Play/Player.cs

@@ -72,7 +72,7 @@ namespace osu.Game.Screens.Play
 
         private Container hitRendererContainer;
 
-        private HudOverlay hudOverlay;
+        private HUDOverlay hudOverlay;
         private PauseOverlay pauseOverlay;
         private FailOverlay failOverlay;
 
@@ -154,7 +154,7 @@ namespace osu.Game.Screens.Play
 
             scoreProcessor = HitRenderer.CreateScoreProcessor();
 
-            hudOverlay = new StandardHudOverlay()
+            hudOverlay = new StandardHUDOverlay()
             {
                 Anchor = Anchor.Centre,
                 Origin = Anchor.Centre
@@ -169,8 +169,8 @@ namespace osu.Game.Screens.Play
             hudOverlay.Progress.AllowSeeking = HitRenderer.HasReplayLoaded;
             hudOverlay.Progress.OnSeek = pos => decoupledClock.Seek(pos);
 
-            hudOverlay.ModsContainer.ShowMods = HitRenderer.HasReplayLoaded;
+            hudOverlay.ModDisplay.ShowMods = HitRenderer.HasReplayLoaded;
-            hudOverlay.ModsContainer.Mods.BindTo(Beatmap.Mods);
+            hudOverlay.ModDisplay.Current.BindTo(Beatmap.Mods);
 
             //bind HitRenderer to ScoreProcessor and ourselves (for a pass situation)
             HitRenderer.OnAllJudged += onCompletion;

osu.Game/Screens/Play/StandardHudOverlay.cs

@@ -1,18 +1,18 @@
 // Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
 // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
 
-using OpenTK;
 using osu.Framework.Allocation;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Primitives;
 using osu.Game.Graphics;
 using osu.Game.Graphics.UserInterface;
 using osu.Game.Rulesets.Scoring;
-using osu.Game.Screens.Play;
+using osu.Game.Screens.Play.HUD;
+using OpenTK;
 
-namespace osu.Game.Rulesets.UI
+namespace osu.Game.Screens.Play
 {
-    public class StandardHudOverlay : HudOverlay
+    public class StandardHUDOverlay : HUDOverlay
     {
         protected override RollingCounter<double> CreateAccuracyCounter() => new PercentageCounter
         {
@@ -64,12 +64,12 @@ namespace osu.Game.Rulesets.UI
             RelativeSizeAxes = Axes.X,
         };
 
-        protected override ModsContainer CreateModsContainer() => new ModsContainer
+        protected override ModDisplay CreateModsContainer() => new ModDisplay
         {
             Anchor = Anchor.TopRight,
             Origin = Anchor.TopRight,
             AutoSizeAxes = Axes.Both,
-            Position = new Vector2(0, 25),
+            Margin = new MarginPadding { Top = 20, Right = 10 },
         };
 
         [BackgroundDependencyLoader]

osu.Game/osu.Game.csproj

@@ -178,10 +178,9 @@
     <Compile Include="Database\RulesetDatabase.cs" />
     <Compile Include="Rulesets\Scoring\Score.cs" />
     <Compile Include="Rulesets\Scoring\ScoreProcessor.cs" />
-    <Compile Include="Rulesets\UI\HealthDisplay.cs" />
+    <Compile Include="Screens\Play\HUD\HealthDisplay.cs" />
-    <Compile Include="Rulesets\UI\HudOverlay.cs" />
+    <Compile Include="Screens\Play\HUDOverlay.cs" />
-    <Compile Include="Rulesets\UI\StandardHealthDisplay.cs" />
+    <Compile Include="Screens\Play\HUD\StandardHealthDisplay.cs" />
-    <Compile Include="Rulesets\UI\StandardHudOverlay.cs" />
     <Compile Include="Online\API\IOnlineComponent.cs" />
     <Compile Include="Online\API\Requests\GetScoresRequest.cs" />
     <Compile Include="Online\API\Requests\GetBeatmapDetailsRequest.cs" />
@@ -228,8 +227,9 @@
     <Compile Include="Screens\Charts\ChartInfo.cs" />
     <Compile Include="Screens\Edit\Editor.cs" />
     <Compile Include="Screens\Play\HotkeyRetryOverlay.cs" />
-    <Compile Include="Screens\Play\ModsContainer.cs" />
+    <Compile Include="Screens\Play\HUD\ModDisplay.cs" />
     <Compile Include="Screens\Play\SquareGraph.cs" />
+    <Compile Include="Screens\Play\StandardHUDOverlay.cs" />
     <Compile Include="Screens\Ranking\ResultsPage.cs" />
     <Compile Include="Screens\Ranking\ResultsPageRanking.cs" />
     <Compile Include="Screens\Ranking\ResultsPageScore.cs" />
@@ -255,7 +255,7 @@
     <Compile Include="Screens\Play\PlayerLoader.cs" />
     <Compile Include="Screens\Play\ReplayPlayer.cs" />
     <Compile Include="Screens\Play\SkipButton.cs" />
-    <Compile Include="Rulesets\UI\StandardComboCounter.cs" />
+    <Compile Include="Screens\Play\HUD\StandardComboCounter.cs" />
     <Compile Include="Screens\Ranking\AspectContainer.cs" />
     <Compile Include="Screens\Ranking\ResultMode.cs" />
     <Compile Include="Screens\Ranking\ResultModeButton.cs" />
@@ -280,8 +280,8 @@
     <Compile Include="Rulesets\UI\HitRenderer.cs" />
     <Compile Include="Rulesets\UI\Playfield.cs" />
     <Compile Include="Screens\Select\EditSongSelect.cs" />
-    <Compile Include="Rulesets\UI\ComboCounter.cs" />
+    <Compile Include="Screens\Play\HUD\ComboCounter.cs" />
-    <Compile Include="Rulesets\UI\ComboResultCounter.cs" />
+    <Compile Include="Screens\Play\HUD\ComboResultCounter.cs" />
     <Compile Include="Graphics\UserInterface\RollingCounter.cs" />
     <Compile Include="Graphics\UserInterface\Volume\VolumeControlReceptor.cs" />
     <Compile Include="Input\GlobalHotkeys.cs" />

osu.sln.DotSettings

@@ -182,6 +182,7 @@
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=GL/@EntryIndexedValue">GL</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=GLSL/@EntryIndexedValue">GLSL</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=HID/@EntryIndexedValue">HID</s:String>
+	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=HUD/@EntryIndexedValue">HUD</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=ID/@EntryIndexedValue">ID</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=IP/@EntryIndexedValue">IP</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=IPC/@EntryIndexedValue">IPC</s:String>