From c902c1587a8248d78ba6d6a13af78fc9674f4e9e Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 25 Dec 2018 19:17:32 +0900
Subject: [PATCH] Add tests and modify fallback logic

---
 ...stCaseUpdateableBeatmapBackgroundSprite.cs | 51 +++++++++++++++++++
 .../UpdateableBeatmapBackgroundSprite.cs      |  2 +-
 2 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 osu.Game.Tests/Visual/TestCaseUpdateableBeatmapBackgroundSprite.cs

diff --git a/osu.Game.Tests/Visual/TestCaseUpdateableBeatmapBackgroundSprite.cs b/osu.Game.Tests/Visual/TestCaseUpdateableBeatmapBackgroundSprite.cs
new file mode 100644
index 0000000000..24701fccbc
--- /dev/null
+++ b/osu.Game.Tests/Visual/TestCaseUpdateableBeatmapBackgroundSprite.cs
@@ -0,0 +1,51 @@
+// Copyright (c) 2007-2018 ppy Pty Ltd <contact@ppy.sh>.
+// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
+
+using System.Linq;
+using osu.Framework.Allocation;
+using osu.Framework.Configuration;
+using osu.Framework.Graphics;
+using osu.Game.Beatmaps;
+using osu.Game.Beatmaps.Drawables;
+using osu.Game.Online.API;
+using osu.Game.Online.API.Requests;
+using osu.Game.Rulesets;
+using osu.Game.Tests.Beatmaps.IO;
+
+namespace osu.Game.Tests.Visual
+{
+    public class TestCaseUpdateableBeatmapBackgroundSprite : OsuTestCase
+    {
+        private UpdateableBeatmapBackgroundSprite backgroundSprite;
+
+        [Resolved]
+        private BeatmapManager beatmaps { get; set; }
+
+        [BackgroundDependencyLoader]
+        private void load(OsuGameBase osu, APIAccess api, RulesetStore rulesets)
+        {
+            Bindable<BeatmapInfo> beatmapBindable = new Bindable<BeatmapInfo>();
+
+            var imported = ImportBeatmapTest.LoadOszIntoOsu(osu);
+
+            Child = backgroundSprite = new UpdateableBeatmapBackgroundSprite { RelativeSizeAxes = Axes.Both };
+
+            backgroundSprite.Beatmap.BindTo(beatmapBindable);
+
+            var req = new GetBeatmapSetRequest(1);
+            api.Queue(req);
+
+            AddStep("null", () => beatmapBindable.Value = null);
+
+            AddStep("imported", () => beatmapBindable.Value = imported.Beatmaps.First());
+
+            if (api.IsLoggedIn)
+                AddUntilStep(() => req.Result != null, "wait for api response");
+
+            AddStep("online", () => beatmapBindable.Value = new BeatmapInfo
+            {
+                BeatmapSet = req.Result?.ToBeatmapSet(rulesets)
+            });
+        }
+    }
+}
diff --git a/osu.Game/Beatmaps/Drawables/UpdateableBeatmapBackgroundSprite.cs b/osu.Game/Beatmaps/Drawables/UpdateableBeatmapBackgroundSprite.cs
index 1808325466..fd00576d21 100644
--- a/osu.Game/Beatmaps/Drawables/UpdateableBeatmapBackgroundSprite.cs
+++ b/osu.Game/Beatmaps/Drawables/UpdateableBeatmapBackgroundSprite.cs
@@ -29,7 +29,7 @@ namespace osu.Game.Beatmaps.Drawables
 
             var localBeatmap = beatmaps.GetWorkingBeatmap(model);
 
-            if (localBeatmap == beatmaps.DefaultBeatmap && model?.BeatmapSet?.OnlineInfo != null)
+            if (localBeatmap.BeatmapInfo.ID == 0 && model?.BeatmapSet?.OnlineInfo != null)
                 drawable = new BeatmapSetCover(model.BeatmapSet);
             else
                 drawable = new BeatmapBackgroundSprite(localBeatmap);