h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-11 02:57:18 +08:00
Code Issues Releases Wiki Activity

Do not give swell ticks any visual representation

Browse Source 
Why is this a thing at all? How has it survived this long? I don't know.

As far as I can tell this only manifests on selected beatmaps with "slow
swells" that spend the entire beatmap moving in the background. On other
beatmaps the tick is faded out, probably due to the initial transform
application that normally "works" but fails hard on these slow swells.

Can be seen on https://osu.ppy.sh/beatmapsets/1432454#taiko/2948222.
This commit is contained in:
Bartłomiej Dach 2025-02-24 15:24:18 +01:00
parent e9b8154090
commit c82cf40928
No known key found for this signature in database
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableSwellTick.cs
View File

@ -4,9 +4,7 @@
#nullable disable #nullable disable
using JetBrains.Annotations; using JetBrains.Annotations;
using osu.Framework.Graphics;
using osu.Framework.Input.Events; using osu.Framework.Input.Events;
using osu.Game.Rulesets.Taiko.Skinning.Default;
using osu.Game.Skinning; using osu.Game.Skinning;
namespace osu.Game.Rulesets.Taiko.Objects.Drawables namespace osu.Game.Rulesets.Taiko.Objects.Drawables
@ -25,8 +23,6 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
{ {
} }
protected override void UpdateInitialTransforms() => this.FadeOut();
public void TriggerResult(bool hit) public void TriggerResult(bool hit)
{ {
HitObject.StartTime = Time.Current; HitObject.StartTime = Time.Current;
@ -43,7 +39,6 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
public override bool OnPressed(KeyBindingPressEvent<TaikoAction> e) => false; public override bool OnPressed(KeyBindingPressEvent<TaikoAction> e) => false;
protected override SkinnableDrawable CreateMainPiece() => new SkinnableDrawable(new TaikoSkinComponentLookup(TaikoSkinComponents.DrumRollTick), protected override SkinnableDrawable CreateMainPiece() => null;
_ => new TickPiece());
} }
} }

6
osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs
View File

@ -154,9 +154,13 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
if (MainPiece != null) if (MainPiece != null)
Content.Remove(MainPiece, true); Content.Remove(MainPiece, true);
Content.Add(MainPiece = CreateMainPiece()); MainPiece = CreateMainPiece();
if (MainPiece != null)
Content.Add(MainPiece);
} }
[CanBeNull]
protected abstract SkinnableDrawable CreateMainPiece(); protected abstract SkinnableDrawable CreateMainPiece();
} }
} }