h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-06 07:42:55 +08:00
Code Issues Releases Wiki Activity

Fix inspections in test scene

Browse Source
This commit is contained in:
Dean Herbert 2022-01-29 14:06:43 +09:00
parent 035a84e75c
commit c7580a5177
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
osu.Game.Rulesets.Mania.Tests/Mods/TestSceneManiaModHoldOff.cs
View File

@ -35,7 +35,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
foreach (HoldNote h in testBeatmap.HitObjects.OfType<HoldNote>()) foreach (HoldNote h in testBeatmap.HitObjects.OfType<HoldNote>())
{ {
noteValues.Add(ManiaModHoldOff.GetNoteDurationInBeatLength(h, (ManiaBeatmap)testBeatmap)); noteValues.Add(ManiaModHoldOff.GetNoteDurationInBeatLength(h, testBeatmap));
} }
noteValues.Sort(); noteValues.Sort();
@ -68,7 +68,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
if (h.GetType() == typeof(HoldNote)) if (h.GetType() == typeof(HoldNote))
{ {
var noteValue = ManiaModHoldOff.GetNoteDurationInBeatLength((HoldNote)h, (ManiaBeatmap)rawBeatmap); double noteValue = ManiaModHoldOff.GetNoteDurationInBeatLength((HoldNote)h, rawBeatmap);
if (noteValue >= beatSnapValue) if (noteValue >= beatSnapValue)
{ {
@ -78,7 +78,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
} }
} }
Assert.That(testBeatmap.HitObjects.Count() == expectedObjectCount); Assert.That(testBeatmap.HitObjects.Count == expectedObjectCount);
} }
[Test] [Test]
@ -86,16 +86,16 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
{ {
// A lower minimum beat snap divisor should only make the map harder, never easier // A lower minimum beat snap divisor should only make the map harder, never easier
// (as more notes can be spawned) // (as more notes can be spawned)
var beatmaps = new ManiaBeatmap[] var beatmaps = new[]
{ {
createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Whole), createModdedBeatmap(),
createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Half), createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Half),
createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Quarter), createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Quarter),
createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Eighth), createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Eighth),
createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Sixteenth) createModdedBeatmap(ManiaModHoldOff.BeatDivisors.Sixteenth)
}; };
var mapDifficulties = new double[beatmaps.Length]; double[] mapDifficulties = new double[beatmaps.Length];
for (int i = 0; i < mapDifficulties.Length; i++) for (int i = 0; i < mapDifficulties.Length; i++)
{ {
@ -114,8 +114,10 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
private static ManiaBeatmap createModdedBeatmap(ManiaModHoldOff.BeatDivisors minBeatSnap = ManiaModHoldOff.BeatDivisors.Whole) private static ManiaBeatmap createModdedBeatmap(ManiaModHoldOff.BeatDivisors minBeatSnap = ManiaModHoldOff.BeatDivisors.Whole)
{ {
var beatmap = createRawBeatmap(); var beatmap = createRawBeatmap();
var holdOffMod = new ManiaModHoldOff(); var holdOffMod = new ManiaModHoldOff
holdOffMod.MinBeatSnap.Value = minBeatSnap; // Set the specified beat snap setting {
MinBeatSnap = { Value = minBeatSnap }
};
Assert.AreEqual(holdOffMod.MinBeatSnap.Value, minBeatSnap); Assert.AreEqual(holdOffMod.MinBeatSnap.Value, minBeatSnap);
foreach (var hitObject in beatmap.HitObjects) foreach (var hitObject in beatmap.HitObjects)
@ -123,7 +125,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
holdOffMod.ApplyToBeatmap(beatmap); holdOffMod.ApplyToBeatmap(beatmap);
return (ManiaBeatmap)beatmap; return beatmap;
} }
private static ManiaBeatmap createRawBeatmap() private static ManiaBeatmap createRawBeatmap()