h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-29 13:42:54 +08:00
Code Issues Releases Wiki Activity

Fix scores not using correct filename/display strings

Browse Source 
I've updated all cases where we should have been using
`GetDisplayString()` anyway, but left the `ToString()` implementations
in place for safety. They should probably be removed in the future.
This commit is contained in:
Dean Herbert 2022-01-13 16:56:09 +09:00
parent 93c78253d6
commit c61419dfe5
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Database/LegacyExporter.cs
View File

@ -35,7 +35,7 @@ namespace osu.Game.Database
/// <param name="item">The item to export.</param> /// <param name="item">The item to export.</param>
public void Export(TModel item) public void Export(TModel item)
{ {
string filename = $"{item.ToString().GetValidArchiveContentFilename()}{FileExtension}"; string filename = $"{item.GetDisplayString().GetValidArchiveContentFilename()}{FileExtension}";
using (var stream = exportStorage.GetStream(filename, FileAccess.Write, FileMode.Create)) using (var stream = exportStorage.GetStream(filename, FileAccess.Write, FileMode.Create))
ExportModelTo(item, stream); ExportModelTo(item, stream);

2
osu.Game/Scoring/ScoreInfo.cs
View File

@ -274,5 +274,7 @@ namespace osu.Game.Scoring
} }
#endregion #endregion
public override string ToString() => this.GetDisplayTitle();
} }
} }

2
osu.Game/Stores/RealmArchiveModelImporter.cs
View File

@ -169,7 +169,7 @@ namespace osu.Game.Stores
else else
{ {
notification.CompletionText = imported.Count == 1 notification.CompletionText = imported.Count == 1
? $"Imported {imported.First()}!" ? $"Imported {imported.First().GetDisplayString()}!"
: $"Imported {imported.Count} {HumanisedModelName}s!"; : $"Imported {imported.Count} {HumanisedModelName}s!";
if (imported.Count > 0 && PostImport != null) if (imported.Count > 0 && PostImport != null)