h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-15 09:22:54 +08:00
Code Issues Releases Wiki Activity

Rename methods and add xmldoc

Browse Source
This commit is contained in:
Dean Herbert 2022-01-15 23:55:11 +09:00
parent 64c499d9d6
commit c5cae4e3ee
5 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/ControlPointPart.cs
View File

@ -36,7 +36,7 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
// as an optimisation, don't add a visualisation if there are already groups with the same types in close proximity. // as an optimisation, don't add a visualisation if there are already groups with the same types in close proximity.
// for newly added control points (ie. lazer editor first where group is added empty) we always skip for simplicity. // for newly added control points (ie. lazer editor first where group is added empty) we always skip for simplicity.
// that is fine, because cases where this is causing a performance issue are mostly where external tools were used to create an insane number of points. // that is fine, because cases where this is causing a performance issue are mostly where external tools were used to create an insane number of points.
if (Children.Any(g => Math.Abs(g.Group.Time - group.Time) < 1000 && g.IsRedundant(group))) if (Children.Any(g => Math.Abs(g.Group.Time - group.Time) < 1000 && g.IsVisuallyRedundant(group)))
continue; continue;
Add(new GroupVisualisation(group)); Add(new GroupVisualisation(group));

2
osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/ControlPointVisualisation.cs
View File

@ -27,6 +27,6 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
Colour = Point.GetRepresentingColour(colours); Colour = Point.GetRepresentingColour(colours);
} }
public bool IsRedundant(ControlPoint other) => other.GetType() == Point.GetType(); public bool IsVisuallyRedundant(ControlPoint other) => other.GetType() == Point.GetType();
} }
} }

2
osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/EffectPointVisualisation.cs
View File

@ -70,6 +70,6 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
} }
// kiai sections display duration, so are required to be visualised. // kiai sections display duration, so are required to be visualised.
public bool IsRedundant(ControlPoint other) => (other as EffectControlPoint)?.KiaiMode == effect.KiaiMode; public bool IsVisuallyRedundant(ControlPoint other) => (other as EffectControlPoint)?.KiaiMode == effect.KiaiMode;
} }
} }

6
osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/GroupVisualisation.cs
View File

@ -61,9 +61,7 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
/// <summary> /// <summary>
/// For display purposes, check whether the proposed group is made redundant by this visualisation group. /// For display purposes, check whether the proposed group is made redundant by this visualisation group.
/// </summary> /// </summary>
/// <param name="other"></param> public bool IsVisuallyRedundant(ControlPointGroup other) =>
/// <returns></returns> other.ControlPoints.Any(c => InternalChildren.OfType<IControlPointVisualisationRedundant>().Any(c2 => c2.IsVisuallyRedundant(c)));
public bool IsRedundant(ControlPointGroup other) =>
other.ControlPoints.Any(c => InternalChildren.OfType<IControlPointVisualisationRedundant>().Any(c2 => c2.IsRedundant(c)));
} }
} }

5
osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/IControlPointVisualisationRedundant.cs
View File

@ -7,6 +7,9 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
{ {
public interface IControlPointVisualisationRedundant public interface IControlPointVisualisationRedundant
{ {
bool IsRedundant(ControlPoint other); /// <summary>
/// For display purposes, check whether the proposed point is made redundant by this visualisation.
/// </summary>
bool IsVisuallyRedundant(ControlPoint other);
} }
} }