h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 20:22:55 +08:00
Code Issues Releases Wiki Activity

Using field properties to set mute / unmute instead of separate methods

Browse Source
This commit is contained in:
aQaTL 2018-01-20 11:45:04 +01:00
parent 4a85266fca
commit c4feb67bce
No known key found for this signature in database
GPG Key ID: 181719411A8555F0
2 changed files with 14 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
osu.Game/Graphics/UserInterface/Volume/VolumeControl.cs
View File

@ -85,12 +85,8 @@ namespace osu.Game.Graphics.UserInterface.Volume
volumeMeterMaster.Increase();
return true;
case GlobalAction.ToggleMute:
if (State == Visibility.Hidden)
Show();
if (IsMuted)
Unmute();
else
Mute();
Muted = !Muted;
return true;
}
@ -107,16 +103,10 @@ namespace osu.Game.Graphics.UserInterface.Volume
private readonly BindableBool muted = new BindableBool();
public bool IsMuted => muted.Value;
public void Mute()
public bool Muted
{
muted.Value = true;
}
public void Unmute()
{
muted.Value = false;
get => muted.Value;
set => muted.Value = value;
}
[BackgroundDependencyLoader]
@ -129,11 +119,15 @@ namespace osu.Game.Graphics.UserInterface.Volume
muted.ValueChanged += mute =>
{
if (mute)
{
audio.AddAdjustment(AdjustableProperty.Volume, muteBindable);
muteIcon.Icon = FontAwesome.fa_volume_off;
}
else
{
audio.RemoveAdjustment(AdjustableProperty.Volume, muteBindable);
muteIcon.Icon = mute ? FontAwesome.fa_volume_off : FontAwesome.fa_volume_up;
muteIcon.Icon = FontAwesome.fa_volume_up;
}
};
}

6
osu.Game/OsuGame.cs
View File

@ -396,8 +396,8 @@ namespace osu.Game
base.OnDeactivated();
if (muteWhenInactive)
{
wasMuted = volume.IsMuted;
volume.Mute();
wasMuted = volume.Muted;
volume.Muted = true;
}
}
@ -405,7 +405,7 @@ namespace osu.Game
{
base.OnActivated();
if (IsLoaded && muteWhenInactive && !wasMuted)
volume.Unmute();
volume.Muted = false;
}
public bool OnReleased(GlobalAction action) => false;