h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 19:42:55 +08:00
Code Issues Releases Wiki Activity

Add local handling of cases where a beatmap's file cannot be found on disk

Browse Source
This commit is contained in:
Dean Herbert 2022-07-07 14:29:15 +09:00
parent e5dd7b1654
commit c4b6893709
1 changed files with 65 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
osu.Game/Beatmaps/WorkingBeatmapCache.cs
View File

@ -137,8 +137,17 @@ namespace osu.Game.Beatmaps
try try
{ {
using (var stream = new LineBufferedReader(GetStream(BeatmapSetInfo.GetPathForFile(BeatmapInfo.Path)))) string fileStorePath = BeatmapSetInfo.GetPathForFile(BeatmapInfo.Path);
return Decoder.GetDecoder<Beatmap>(stream).Decode(stream); var stream = GetStream(fileStorePath);
if (stream == null)
{
Logger.Log($"Beatmap failed to load (file {BeatmapInfo.Path} not found on disk at expected location {fileStorePath}).", level: LogLevel.Error);
return null;
}
using (var reader = new LineBufferedReader(stream))
return Decoder.GetDecoder<Beatmap>(reader).Decode(reader);
} }
catch (Exception e) catch (Exception e)
{ {
@ -154,7 +163,16 @@ namespace osu.Game.Beatmaps
try try
{ {
return resources.LargeTextureStore.Get(BeatmapSetInfo.GetPathForFile(Metadata.BackgroundFile)); string fileStorePath = BeatmapSetInfo.GetPathForFile(Metadata.BackgroundFile);
var texture = resources.LargeTextureStore.Get(fileStorePath);
if (texture == null)
{
Logger.Log($"Beatmap background failed to load (file {Metadata.BackgroundFile} not found on disk at expected location {fileStorePath}).", level: LogLevel.Error);
return null;
}
return texture;
} }
catch (Exception e) catch (Exception e)
{ {
@ -173,7 +191,16 @@ namespace osu.Game.Beatmaps
try try
{ {
return resources.Tracks.Get(BeatmapSetInfo.GetPathForFile(Metadata.AudioFile)); string fileStorePath = BeatmapSetInfo.GetPathForFile(Metadata.AudioFile);
var track = resources.Tracks.Get(fileStorePath);
if (track == null)
{
Logger.Log($"Beatmap failed to load (file {Metadata.AudioFile} not found on disk at expected location {fileStorePath}).", level: LogLevel.Error);
return null;
}
return track;
} }
catch (Exception e) catch (Exception e)
{ {
@ -192,8 +219,17 @@ namespace osu.Game.Beatmaps
try try
{ {
var trackData = GetStream(BeatmapSetInfo.GetPathForFile(Metadata.AudioFile)); string fileStorePath = BeatmapSetInfo.GetPathForFile(Metadata.AudioFile);
return trackData == null ? null : new Waveform(trackData);
var trackData = GetStream(fileStorePath);
if (trackData == null)
{
Logger.Log($"Beatmap waveform failed to load (file {Metadata.AudioFile} not found on disk at expected location {fileStorePath}).", level: LogLevel.Error);
return null;
}
return new Waveform(trackData);
} }
catch (Exception e) catch (Exception e)
{ {
@ -211,19 +247,37 @@ namespace osu.Game.Beatmaps
try try
{ {
using (var stream = new LineBufferedReader(GetStream(BeatmapSetInfo.GetPathForFile(BeatmapInfo.Path)))) string fileStorePath = BeatmapSetInfo.GetPathForFile(BeatmapInfo.Path);
var stream = GetStream(fileStorePath);
if (stream == null)
{ {
var decoder = Decoder.GetDecoder<Storyboard>(stream); Logger.Log($"Beatmap failed to load (file {BeatmapInfo.Path} not found on disk at expected location {fileStorePath})", level: LogLevel.Error);
return null;
}
using (var reader = new LineBufferedReader(stream))
{
var decoder = Decoder.GetDecoder<Storyboard>(reader);
string storyboardFilename = BeatmapSetInfo?.Files.FirstOrDefault(f => f.Filename.EndsWith(".osb", StringComparison.OrdinalIgnoreCase))?.Filename; string storyboardFilename = BeatmapSetInfo?.Files.FirstOrDefault(f => f.Filename.EndsWith(".osb", StringComparison.OrdinalIgnoreCase))?.Filename;
// todo: support loading from both set-wide storyboard *and* beatmap specific. // todo: support loading from both set-wide storyboard *and* beatmap specific.
if (string.IsNullOrEmpty(storyboardFilename)) if (string.IsNullOrEmpty(storyboardFilename))
storyboard = decoder.Decode(stream); storyboard = decoder.Decode(reader);
else else
{ {
using (var secondaryStream = new LineBufferedReader(GetStream(BeatmapSetInfo.GetPathForFile(storyboardFilename)))) string storyboardFileStorePath = BeatmapSetInfo.GetPathForFile(storyboardFilename);
storyboard = decoder.Decode(stream, secondaryStream); var secondaryStream = GetStream(storyboardFileStorePath);
if (secondaryStream == null)
{
Logger.Log($"Storyboard failed to load (file {storyboardFilename} not found on disk at expected location {fileStorePath})", level: LogLevel.Error);
return null;
}
using (var secondaryReader = new LineBufferedReader(secondaryStream))
storyboard = decoder.Decode(reader, secondaryReader);
} }
} }
} }