From 5a83687a27c8c581ee0665e068374733ac99b9be Mon Sep 17 00:00:00 2001 From: DrabWeb Date: Fri, 3 Mar 2017 18:02:31 -0400 Subject: [PATCH 1/2] Small cleanups --- osu.Game/Overlays/Mods/ModSelectOverlay.cs | 6 +----- osu.Game/Overlays/WaveOverlayContainer.cs | 8 -------- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/osu.Game/Overlays/Mods/ModSelectOverlay.cs b/osu.Game/Overlays/Mods/ModSelectOverlay.cs index 0a5d0e49e1..a969d71347 100644 --- a/osu.Game/Overlays/Mods/ModSelectOverlay.cs +++ b/osu.Game/Overlays/Mods/ModSelectOverlay.cs @@ -33,7 +33,7 @@ namespace osu.Game.Overlays.Mods private FillFlowContainer modSectionsContainer; - public Bindable SelectedMods = new Bindable(); + public readonly Bindable SelectedMods = new Bindable(); public readonly Bindable PlayMode = new Bindable(); @@ -95,8 +95,6 @@ namespace osu.Game.Overlays.Mods section.ButtonsContainer.MoveToX(100f, APPEAR_DURATION, EasingTypes.InSine); section.ButtonsContainer.FadeOut(APPEAR_DURATION, EasingTypes.InSine); } - - TriggerFocusLost(); } protected override void PopIn() @@ -112,8 +110,6 @@ namespace osu.Game.Overlays.Mods section.ButtonsContainer.MoveToX(0, button_duration, EasingTypes.OutQuint); section.ButtonsContainer.FadeIn(button_duration, EasingTypes.OutQuint); } - - Schedule(TriggerFocusContention); } public void DeselectAll() diff --git a/osu.Game/Overlays/WaveOverlayContainer.cs b/osu.Game/Overlays/WaveOverlayContainer.cs index 37a939005b..203f678e61 100644 --- a/osu.Game/Overlays/WaveOverlayContainer.cs +++ b/osu.Game/Overlays/WaveOverlayContainer.cs @@ -123,14 +123,6 @@ namespace osu.Game.Overlays RelativeSizeAxes = Axes.Both, Anchor = Anchor.BottomCentre, Origin = Anchor.BottomCentre, - Children = new Drawable[] - { - new Box - { - RelativeSizeAxes = Axes.Both, - Colour = Color4.White.Opacity(50), - }, - }, }); } From 9141d244bf2c75412b3f27a91fdff34b65174c84 Mon Sep 17 00:00:00 2001 From: DrabWeb Date: Fri, 3 Mar 2017 18:05:43 -0400 Subject: [PATCH 2/2] Focus trigger in WaveOverlayContainer --- osu.Game/Overlays/WaveOverlayContainer.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/osu.Game/Overlays/WaveOverlayContainer.cs b/osu.Game/Overlays/WaveOverlayContainer.cs index 203f678e61..fba6244d15 100644 --- a/osu.Game/Overlays/WaveOverlayContainer.cs +++ b/osu.Game/Overlays/WaveOverlayContainer.cs @@ -128,6 +128,8 @@ namespace osu.Game.Overlays protected override void PopIn() { + base.PopIn(); + foreach (var w in wavesContainer.Children) w.State = Visibility.Visible; @@ -137,6 +139,8 @@ namespace osu.Game.Overlays protected override void PopOut() { + base.PopOut(); + contentContainer.FadeOut(DISAPPEAR_DURATION, EasingTypes.In); contentContainer.MoveToY(DrawHeight * 2f, DISAPPEAR_DURATION, EasingTypes.In);