h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 01:53:01 +08:00
Code Issues Releases Wiki Activity

Fix results screen accuracy circle not showing correctly for failed S with no flair

Browse Source
This commit is contained in:
Joseph Madamba 2024-03-06 20:08:46 -08:00
parent 56caf19350
commit c36232bc02
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
osu.Game/Screens/Ranking/Expanded/Accuracy/AccuracyCircle.cs
View File

@ -194,11 +194,11 @@ namespace osu.Game.Screens.Ranking.Expanded.Accuracy
rankText = new RankText(score.Rank) rankText = new RankText(score.Rank)
}; };
if (isFailedSDueToMisses)
AddInternal(failedSRankText = new RankText(ScoreRank.S));
if (withFlair) if (withFlair)
{ {
if (isFailedSDueToMisses)
AddInternal(failedSRankText = new RankText(ScoreRank.S));
var applauseSamples = new List<string> { applauseSampleName }; var applauseSamples = new List<string> { applauseSampleName };
if (score.Rank >= ScoreRank.B) if (score.Rank >= ScoreRank.B)
// when rank is B or higher, play legacy applause sample on legacy skins. // when rank is B or higher, play legacy applause sample on legacy skins.
@ -326,24 +326,25 @@ namespace osu.Game.Screens.Ranking.Expanded.Accuracy
{ {
rankText.Appear(); rankText.Appear();
if (!withFlair) return; if (withFlair)
Schedule(() =>
{
isTicking = false;
rankImpactSound.Play();
});
const double applause_pre_delay = 545f;
const double applause_volume = 0.8f;
using (BeginDelayedSequence(applause_pre_delay))
{ {
Schedule(() => Schedule(() =>
{ {
rankApplauseSound.VolumeTo(applause_volume); isTicking = false;
rankApplauseSound.Play(); rankImpactSound.Play();
}); });
const double applause_pre_delay = 545f;
const double applause_volume = 0.8f;
using (BeginDelayedSequence(applause_pre_delay))
{
Schedule(() =>
{
rankApplauseSound.VolumeTo(applause_volume);
rankApplauseSound.Play();
});
}
} }
} }