h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 04:02:57 +08:00
Code Issues Releases Wiki Activity

Fix results screen accuracy circle not showing correctly for failed S with no flair

Browse Source
This commit is contained in:
Joseph Madamba 2024-03-06 20:08:46 -08:00
parent 56caf19350
commit c36232bc02
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Screens/Ranking/Expanded/Accuracy/AccuracyCircle.cs
View File

@ -194,11 +194,11 @@ namespace osu.Game.Screens.Ranking.Expanded.Accuracy
rankText = new RankText(score.Rank) rankText = new RankText(score.Rank)
}; };
if (withFlair)
{
if (isFailedSDueToMisses) if (isFailedSDueToMisses)
AddInternal(failedSRankText = new RankText(ScoreRank.S)); AddInternal(failedSRankText = new RankText(ScoreRank.S));
if (withFlair)
{
var applauseSamples = new List<string> { applauseSampleName }; var applauseSamples = new List<string> { applauseSampleName };
if (score.Rank >= ScoreRank.B) if (score.Rank >= ScoreRank.B)
// when rank is B or higher, play legacy applause sample on legacy skins. // when rank is B or higher, play legacy applause sample on legacy skins.
@ -326,8 +326,8 @@ namespace osu.Game.Screens.Ranking.Expanded.Accuracy
{ {
rankText.Appear(); rankText.Appear();
if (!withFlair) return; if (withFlair)
{
Schedule(() => Schedule(() =>
{ {
isTicking = false; isTicking = false;
@ -346,6 +346,7 @@ namespace osu.Game.Screens.Ranking.Expanded.Accuracy
}); });
} }
} }
}
if (isFailedSDueToMisses) if (isFailedSDueToMisses)
{ {