From 1d6b6a7828feb447a69e16e39ad0ffb088de05b4 Mon Sep 17 00:00:00 2001 From: Joehu Date: Fri, 21 Jun 2019 08:06:57 -0700 Subject: [PATCH 1/3] Fix audio being dimmed on preview tracks --- osu.Game/Audio/PreviewTrackManager.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/osu.Game/Audio/PreviewTrackManager.cs b/osu.Game/Audio/PreviewTrackManager.cs index 6e162ca95e..bb6fba9bda 100644 --- a/osu.Game/Audio/PreviewTrackManager.cs +++ b/osu.Game/Audio/PreviewTrackManager.cs @@ -36,8 +36,6 @@ namespace osu.Game.Audio trackStore.AddAdjustment(AdjustableProperty.Volume, audio.VolumeTrack); this.audio = audio; - - config.BindWith(FrameworkSetting.VolumeMusic, trackStore.Volume); } /// From 74e99b2915d4a8ffd14719c631f29b5db9850cfa Mon Sep 17 00:00:00 2001 From: Joehu Date: Fri, 21 Jun 2019 08:11:10 -0700 Subject: [PATCH 2/3] Remove unused parameter --- osu.Game/Audio/PreviewTrackManager.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Audio/PreviewTrackManager.cs b/osu.Game/Audio/PreviewTrackManager.cs index bb6fba9bda..4f5088f490 100644 --- a/osu.Game/Audio/PreviewTrackManager.cs +++ b/osu.Game/Audio/PreviewTrackManager.cs @@ -26,7 +26,7 @@ namespace osu.Game.Audio private TrackManagerPreviewTrack current; [BackgroundDependencyLoader] - private void load(AudioManager audio, FrameworkConfigManager config) + private void load(AudioManager audio) { // this is a temporary solution to get around muting ourselves. // todo: update this once we have a BackgroundTrackManager or similar. From 36f59ec86dd6ff7613f28dc6aee041634fc6f257 Mon Sep 17 00:00:00 2001 From: Joehu Date: Fri, 21 Jun 2019 08:29:45 -0700 Subject: [PATCH 3/3] Remove unused using --- osu.Game/Audio/PreviewTrackManager.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/osu.Game/Audio/PreviewTrackManager.cs b/osu.Game/Audio/PreviewTrackManager.cs index 4f5088f490..e12c46ef16 100644 --- a/osu.Game/Audio/PreviewTrackManager.cs +++ b/osu.Game/Audio/PreviewTrackManager.cs @@ -9,7 +9,6 @@ using osu.Framework.Allocation; using osu.Framework.Audio; using osu.Framework.Audio.Track; using osu.Framework.Bindables; -using osu.Framework.Configuration; using osu.Framework.Graphics; using osu.Framework.IO.Stores; using osu.Game.Beatmaps;