Merge pull request #9759 from EVAST9919/news-fix

Fix NewsOverlay running request on startup
2026-05-21 05:09:57 +08:00 · 2020-08-05 20:24:17 +09:00
parent 93f8dddb20 3916d98e52
commit c0cfd136dd
1 changed files with 22 additions and 1 deletions
@@ -67,7 +67,28 @@ namespace osu.Game.Overlays
        protected override void LoadComplete()
        {
            base.LoadComplete();
-            article.BindValueChanged(onArticleChanged, true);
+
+            // should not be run until first pop-in to avoid requesting data before user views.
+            article.BindValueChanged(onArticleChanged);
+        }
+
+        private bool displayUpdateRequired = true;
+
+        protected override void PopIn()
+        {
+            base.PopIn();
+
+            if (displayUpdateRequired)
+            {
+                article.TriggerChange();
+                displayUpdateRequired = false;
+            }
+        }
+
+        protected override void PopOutComplete()
+        {
+            base.PopOutComplete();
+            displayUpdateRequired = true;
        }

        public void ShowFrontPage()