From c0a51da11054aba0ffbbbe98555097874cfd0a1e Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 24 Jun 2025 15:33:51 +0900
Subject: [PATCH] Fix player settings overlay potentially disappearing
 unexpectedly

Closes https://github.com/ppy/osu/issues/33793.

Can be tested with this diff:

```diff
diff --git a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
index 635d140a4a..b3a827b699 100644
--- a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
+++ b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
@@ -60,6 +60,8 @@ public PlayerSettingsOverlay()
             Origin = Anchor.TopRight;
             Anchor = Anchor.TopRight;

+            X = 0.01f;
+
             base.Content.Add(content = new FillFlowContainer
             {
                 AutoSizeAxes = Axes.Both,

```
---
 osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
index b285b1b799..635d140a4a 100644
--- a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
+++ b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
@@ -6,6 +6,7 @@ using osu.Framework.Extensions.Color4Extensions;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Colour;
 using osu.Framework.Graphics.Containers;
+using osu.Framework.Graphics.Primitives;
 using osu.Framework.Graphics.Shapes;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Input;
@@ -47,6 +48,12 @@ namespace osu.Game.Screens.Play.HUD
         [Resolved]
         private HUDOverlay? hudOverlay { get; set; }
 
+        // Player settings are kept off the edge of the screen.
+        //
+        // In edge cases, floating point error could result in the whole control getting masked away
+        // while collapsed down, so let's avoid that.
+        protected override bool ComputeIsMaskedAway(RectangleF maskingBounds) => false;
+
         public PlayerSettingsOverlay()
             : base(0, EXPANDED_WIDTH)
         {