h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-10 18:57:20 +08:00
Code Issues Releases Wiki Activity

Fix playlists results screens potentially displaying negative score positions

Browse Source 
Closes https://github.com/ppy/osu/issues/31434.
This commit is contained in:
Bartłomiej Dach 2025-03-03 12:56:28 +01:00
parent 28f9e734f0
commit bf4fa58f72
No known key found for this signature in database
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
osu.Game/Screens/OnlinePlay/Playlists/PlaylistItemResultsScreen.cs
View File

@ -185,6 +185,24 @@ namespace osu.Game.Screens.OnlinePlay.Playlists
{
higherScores = index;
setPositions(index, pivot, -1);
// when paginating the results, it's possible for the user's score to naturally fall down the rankings.
// unmitigated, this can cause scores at the very top of the rankings to have zero or negative positions
// because the positions are counted backwards from the user's score, which has increased in this case during pagination.
// if this happens, just give the top score the first position.
// note that this isn't 100% correct, but it *is* however the most reliable way to mask the problem.
int smallestPosition = index.Scores.Min(s => s.Position ?? 1);
if (smallestPosition < 1)
{
int offset = 1 - smallestPosition;
foreach (var scorePanel in ScorePanelList.GetScorePanels())
scorePanel.ScorePosition.Value += offset;
foreach (var score in index.Scores)
score.Position += offset;
}
}
return await transformScores(index.Scores).ConfigureAwait(false);