h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-31 14:25:10 +08:00
Code Issues Releases Wiki Activity

add a max depth to prevent stack overflow

Browse Source
This commit is contained in:
OliBomby 2024-09-23 13:16:45 +02:00
parent eead6b9eae
commit bf245aa9d6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Utils/GeometryUtils.cs
View File

@ -305,8 +305,11 @@ namespace osu.Game.Utils
// n represents the number of points in P that are not yet processed.
private static (Vector2, float) welzlHelper(List<Vector2> points, ReadOnlySpan<Vector2> r, int n)
{
const int max_depth = 4000;
// Base case when all points processed or |R| = 3
if (n == 0 || r.Length == 3)
// To prevent stack overflow, we stop at a certain depth and give an approximate answer
if (n == 0 || r.Length == 3 || points.Count - n >= max_depth)
return minCircleTrivial(r);
// Pick a random point randomly