From bd869b6cdcd41c3406022fb784f54fe2fdebf849 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Mon, 6 May 2024 13:24:24 +0200
Subject: [PATCH] Add failing tests for looking up users by online ID if
 present when importing scores

---
 osu.Game.Tests/Scores/IO/ImportScoreTest.cs | 82 ++++++++++++++++++++-
 1 file changed, 79 insertions(+), 3 deletions(-)

diff --git a/osu.Game.Tests/Scores/IO/ImportScoreTest.cs b/osu.Game.Tests/Scores/IO/ImportScoreTest.cs
index eb2c098ab8..9c72804a6b 100644
--- a/osu.Game.Tests/Scores/IO/ImportScoreTest.cs
+++ b/osu.Game.Tests/Scores/IO/ImportScoreTest.cs
@@ -287,7 +287,7 @@ namespace osu.Game.Tests.Scores.IO
         }
 
         [Test]
-        public void TestUserLookedUpForOnlineScore()
+        public void TestUserLookedUpByUsernameForOnlineScoreIfUserIDMissing()
         {
             using (HeadlessGameHost host = new CleanRunHeadlessGameHost())
             {
@@ -301,6 +301,9 @@ namespace osu.Game.Tests.Scores.IO
                         switch (req)
                         {
                             case GetUserRequest userRequest:
+                                if (userRequest.Lookup != "Test user")
+                                    return false;
+
                                 userRequest.TriggerSuccess(new APIUser
                                 {
                                     Username = "Test user",
@@ -350,7 +353,7 @@ namespace osu.Game.Tests.Scores.IO
         }
 
         [Test]
-        public void TestUserLookedUpForLegacyOnlineScore()
+        public void TestUserLookedUpByUsernameForLegacyOnlineScore()
         {
             using (HeadlessGameHost host = new CleanRunHeadlessGameHost())
             {
@@ -364,6 +367,9 @@ namespace osu.Game.Tests.Scores.IO
                         switch (req)
                         {
                             case GetUserRequest userRequest:
+                                if (userRequest.Lookup != "Test user")
+                                    return false;
+
                                 userRequest.TriggerSuccess(new APIUser
                                 {
                                     Username = "Test user",
@@ -413,7 +419,7 @@ namespace osu.Game.Tests.Scores.IO
         }
 
         [Test]
-        public void TestUserNotLookedUpForOfflineScore()
+        public void TestUserNotLookedUpForOfflineScoreIfUserIDMissing()
         {
             using (HeadlessGameHost host = new CleanRunHeadlessGameHost())
             {
@@ -427,6 +433,9 @@ namespace osu.Game.Tests.Scores.IO
                         switch (req)
                         {
                             case GetUserRequest userRequest:
+                                if (userRequest.Lookup != "Test user")
+                                    return false;
+
                                 userRequest.TriggerSuccess(new APIUser
                                 {
                                     Username = "Test user",
@@ -476,6 +485,73 @@ namespace osu.Game.Tests.Scores.IO
             }
         }
 
+        [Test]
+        public void TestUserLookedUpByOnlineIDIfPresent([Values] bool isOnlineScore)
+        {
+            using (HeadlessGameHost host = new CleanRunHeadlessGameHost())
+            {
+                try
+                {
+                    var osu = LoadOsuIntoHost(host, true);
+
+                    var api = (DummyAPIAccess)osu.API;
+                    api.HandleRequest = req =>
+                    {
+                        switch (req)
+                        {
+                            case GetUserRequest userRequest:
+                                if (userRequest.Lookup != "5555")
+                                    return false;
+
+                                userRequest.TriggerSuccess(new APIUser
+                                {
+                                    Username = "Some other guy",
+                                    CountryCode = CountryCode.DE,
+                                    Id = 5555
+                                });
+                                return true;
+
+                            default:
+                                return false;
+                        }
+                    };
+
+                    var beatmap = BeatmapImportHelper.LoadOszIntoOsu(osu, TestResources.GetQuickTestBeatmapForImport()).GetResultSafely();
+
+                    var toImport = new ScoreInfo
+                    {
+                        Rank = ScoreRank.B,
+                        TotalScore = 987654,
+                        Accuracy = 0.8,
+                        MaxCombo = 500,
+                        Combo = 250,
+                        User = new APIUser { Id = 5555 },
+                        Date = DateTimeOffset.Now,
+                        Ruleset = new OsuRuleset().RulesetInfo,
+                        BeatmapInfo = beatmap.Beatmaps.First()
+                    };
+                    if (isOnlineScore)
+                        toImport.OnlineID = 12345;
+
+                    var imported = LoadScoreIntoOsu(osu, toImport);
+
+                    Assert.AreEqual(toImport.Rank, imported.Rank);
+                    Assert.AreEqual(toImport.TotalScore, imported.TotalScore);
+                    Assert.AreEqual(toImport.Accuracy, imported.Accuracy);
+                    Assert.AreEqual(toImport.MaxCombo, imported.MaxCombo);
+                    Assert.AreEqual(toImport.Date, imported.Date);
+                    Assert.AreEqual(toImport.OnlineID, imported.OnlineID);
+                    Assert.AreEqual("Some other guy", imported.RealmUser.Username);
+                    Assert.AreEqual(5555, imported.RealmUser.OnlineID);
+                    Assert.AreEqual(CountryCode.DE, imported.RealmUser.CountryCode);
+                }
+                finally
+                {
+                    host.Exit();
+                }
+            }
+        }
+
         public static ScoreInfo LoadScoreIntoOsu(OsuGameBase osu, ScoreInfo score, ArchiveReader archive = null)
         {
             // clone to avoid attaching the input score to realm.