From bb998ad687279aee44a1c4e1fb09d665655e418c Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Mon, 24 Mar 2025 16:14:32 +0900 Subject: [PATCH] Fix taiko legacy skins playing scale animations even when skins contain animations Closes https://github.com/ppy/osu/issues/32477. Can be tested using https://drive.google.com/drive/folders/1HUCsTL_iqCGPCyruSSfdSoxL19EQuy_a. --- .../Skinning/Legacy/LegacyHitExplosion.cs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/osu.Game.Rulesets.Taiko/Skinning/Legacy/LegacyHitExplosion.cs b/osu.Game.Rulesets.Taiko/Skinning/Legacy/LegacyHitExplosion.cs index b9a432f3bd..b67648a3b8 100644 --- a/osu.Game.Rulesets.Taiko/Skinning/Legacy/LegacyHitExplosion.cs +++ b/osu.Game.Rulesets.Taiko/Skinning/Legacy/LegacyHitExplosion.cs @@ -60,11 +60,17 @@ namespace osu.Game.Rulesets.Taiko.Skinning.Legacy { const double animation_time = 120; - (sprite as IFramedAnimation)?.GotoFrame(0); + var animation = sprite as IFramedAnimation; + + animation?.GotoFrame(0); (strongSprite as IFramedAnimation)?.GotoFrame(0); this.FadeInFromZero(animation_time).Then().FadeOut(animation_time * 1.5); + // legacy judgements don't play any transforms if they are an animation. + if (animation?.FrameCount > 1) + return; + this.ScaleTo(0.6f) .Then().ScaleTo(1.1f, animation_time * 0.8) .Then().ScaleTo(0.9f, animation_time * 0.4)