h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-15 14:03:01 +08:00
Code Issues Releases Wiki Activity

Fix constant formatting

Browse Source
This commit is contained in:
Dean Herbert 2022-01-31 12:20:51 +09:00
parent b52153e73d
commit bb8dc74e88
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Rulesets.Mania.Tests/Mods/TestSceneManiaModHoldOff.cs
View File

@ -49,7 +49,6 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
// Calculate expected number of objects // Calculate expected number of objects
int expectedObjectCount = 0; int expectedObjectCount = 0;
double beatSnapValue = ManiaModHoldOff.Threshold;
foreach (ManiaHitObject h in rawBeatmap.HitObjects) foreach (ManiaHitObject h in rawBeatmap.HitObjects)
{ {
@ -60,7 +59,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
{ {
double noteValue = ManiaModHoldOff.GetNoteDurationInBeatLength((HoldNote)h, rawBeatmap); double noteValue = ManiaModHoldOff.GetNoteDurationInBeatLength((HoldNote)h, rawBeatmap);
if (noteValue >= beatSnapValue) if (noteValue >= ManiaModHoldOff.END_NOTE_ALLOW_THRESHOLD)
{ {
// Should generate an end note if it's longer than the minimum note value // Should generate an end note if it's longer than the minimum note value
expectedObjectCount++; expectedObjectCount++;

5
osu.Game.Rulesets.Mania/Mods/ManiaModHoldOff.cs
View File

@ -24,7 +24,8 @@ namespace osu.Game.Rulesets.Mania.Mods
public override IconUsage? Icon => FontAwesome.Solid.DotCircle; public override IconUsage? Icon => FontAwesome.Solid.DotCircle;
public override ModType Type => ModType.Conversion; public override ModType Type => ModType.Conversion;
public const double Threshold = 1/2;
public const double END_NOTE_ALLOW_THRESHOLD = 0.5;
public void ApplyToBeatmap(IBeatmap beatmap) public void ApplyToBeatmap(IBeatmap beatmap)
{ {
@ -45,7 +46,7 @@ namespace osu.Game.Rulesets.Mania.Mods
// Don't add an end note if the duration is shorter than the threshold // Don't add an end note if the duration is shorter than the threshold
double noteValue = GetNoteDurationInBeatLength(h, maniaBeatmap); // 1/1, 1/2, 1/4, etc. double noteValue = GetNoteDurationInBeatLength(h, maniaBeatmap); // 1/1, 1/2, 1/4, etc.
if (noteValue >= Threshold) if (noteValue >= END_NOTE_ALLOW_THRESHOLD)
{ {
newObjects.Add(new Note newObjects.Add(new Note
{ {