h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 00:53:21 +08:00
Code Issues Releases Wiki Activity

Fix skin parser not stripping whitespace before parsing

Browse Source
This commit is contained in:
Dean Herbert 2021-03-18 15:36:07 +09:00
parent 822d469b2c
commit bb3c3f302a
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Tests/Resources/skin-with-space.ini Normal file
View File

@ -0,0 +1,2 @@
[General]
Version: 2

9
osu.Game.Tests/Skins/LegacySkinDecoderTest.cs
View File

@ -91,6 +91,15 @@ namespace osu.Game.Tests.Skins
Assert.AreEqual(2.0m, decoder.Decode(stream).LegacyVersion); Assert.AreEqual(2.0m, decoder.Decode(stream).LegacyVersion);
} }
[Test]
public void TestStripWhitespace()
{
var decoder = new LegacySkinDecoder();
using (var resStream = TestResources.OpenResource("skin-with-space.ini"))
using (var stream = new LineBufferedReader(resStream))
Assert.AreEqual(2.0m, decoder.Decode(stream).LegacyVersion);
}
[Test] [Test]
public void TestDecodeLatestVersion() public void TestDecodeLatestVersion()
{ {

2
osu.Game/Beatmaps/Formats/LegacyDecoder.cs
View File

@ -36,6 +36,8 @@ namespace osu.Game.Beatmaps.Formats
if (ShouldSkipLine(line)) if (ShouldSkipLine(line))
continue; continue;
line = line.Trim();
if (line.StartsWith('[') && line.EndsWith(']')) if (line.StartsWith('[') && line.EndsWith(']'))
{ {
if (!Enum.TryParse(line[1..^1], out section)) if (!Enum.TryParse(line[1..^1], out section))