From b97f4a81db6a35ba5fac734bbdb0f8b42a948419 Mon Sep 17 00:00:00 2001
From: Andrei Zavatski <megaman9919@gmail.com>
Date: Sun, 8 Sep 2019 00:27:40 +0300
Subject: [PATCH] Add more testing

---
 .../UserInterface/TestScenePageSelector.cs    | 22 +++++++++++++++++++
 .../Graphics/UserInterface/PageSelector.cs    | 18 +++++++++++++--
 2 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/osu.Game.Tests/Visual/UserInterface/TestScenePageSelector.cs b/osu.Game.Tests/Visual/UserInterface/TestScenePageSelector.cs
index e5efa65c91..cb83fbd028 100644
--- a/osu.Game.Tests/Visual/UserInterface/TestScenePageSelector.cs
+++ b/osu.Game.Tests/Visual/UserInterface/TestScenePageSelector.cs
@@ -22,6 +22,28 @@ namespace osu.Game.Tests.Visual.UserInterface
                 Anchor = Anchor.Centre,
                 Origin = Anchor.Centre,
             };
+
+            AddStep("1 max pages", () => redraw(1));
+            AddStep("10 max pages", () => redraw(10));
+            AddStep("200 max pages, current 199", () => redraw(200, 199));
+            AddStep("200 max pages, current 201", () => redraw(200, 201));
+            AddStep("200 max pages, current -10", () => redraw(200, -10));
+        }
+
+        private void redraw(int maxPages, int currentPage = 0)
+        {
+            Clear();
+
+            var selector = new PageSelector(maxPages)
+            {
+                Anchor = Anchor.Centre,
+                Origin = Anchor.Centre,
+            };
+
+            if (currentPage != 0)
+                selector.CurrentPage.Value = currentPage;
+
+            Add(selector);
         }
     }
 }
diff --git a/osu.Game/Graphics/UserInterface/PageSelector.cs b/osu.Game/Graphics/UserInterface/PageSelector.cs
index 9a5ffad0d4..79a1680e4b 100644
--- a/osu.Game/Graphics/UserInterface/PageSelector.cs
+++ b/osu.Game/Graphics/UserInterface/PageSelector.cs
@@ -59,11 +59,25 @@ namespace osu.Game.Graphics.UserInterface
         {
             base.LoadComplete();
 
-            CurrentPage.BindValueChanged(page => redraw(page.NewValue), true);
+            CurrentPage.BindValueChanged(_ => redraw(), true);
         }
 
-        private void redraw(int newPage)
+        private void redraw()
         {
+            if (CurrentPage.Value > maxPages)
+            {
+                CurrentPage.Value = maxPages;
+                return;
+            }
+
+            if (CurrentPage.Value < 1)
+            {
+                CurrentPage.Value = 1;
+                return;
+            }
+
+            int newPage = CurrentPage.Value;
+
             previousPageButton.Enabled.Value = newPage != 1;
             nextPageButton.Enabled.Value = newPage != maxPages;