h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 05:43:18 +08:00
Code Issues Releases Wiki Activity

Merge pull request #14695 from peppy/avoid-unnecessary-settings-copy

Browse Source 
Avoid unnecessary mod settings copy attempt (when no settings exist to copy)
This commit is contained in:
Dean Herbert 2021-09-09 17:10:32 +09:00 committed by GitHub
commit b864b111d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Online/API/APIMod.cs
View File

@ -53,6 +53,8 @@ namespace osu.Game.Online.API
if (resultMod == null) if (resultMod == null)
throw new InvalidOperationException($"There is no mod in the ruleset ({ruleset.ShortName}) matching the acronym {Acronym}."); throw new InvalidOperationException($"There is no mod in the ruleset ({ruleset.ShortName}) matching the acronym {Acronym}.");
if (Settings.Count > 0)
{
foreach (var (_, property) in resultMod.GetSettingsSourceProperties()) foreach (var (_, property) in resultMod.GetSettingsSourceProperties())
{ {
if (!Settings.TryGetValue(property.Name.Underscore(), out object settingValue)) if (!Settings.TryGetValue(property.Name.Underscore(), out object settingValue))
@ -60,6 +62,7 @@ namespace osu.Game.Online.API
resultMod.CopyAdjustedSetting((IBindable)property.GetValue(resultMod), settingValue); resultMod.CopyAdjustedSetting((IBindable)property.GetValue(resultMod), settingValue);
} }
}
return resultMod; return resultMod;
} }