From 2938ca948808b6852ac5f43092a3f9df811cdda9 Mon Sep 17 00:00:00 2001 From: Jorolf Date: Fri, 13 Oct 2017 20:44:05 +0200 Subject: [PATCH 1/2] fix loading animation not playing --- osu.Game/Overlays/Direct/PlayButton.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/osu.Game/Overlays/Direct/PlayButton.cs b/osu.Game/Overlays/Direct/PlayButton.cs index 32435a4873..e222b8edb8 100644 --- a/osu.Game/Overlays/Direct/PlayButton.cs +++ b/osu.Game/Overlays/Direct/PlayButton.cs @@ -143,6 +143,8 @@ namespace osu.Game.Overlays.Direct { if (trackLoader != null) return; + loading = true; + Add(new AsyncLoadWrapper(trackLoader = new TrackLoader($"https://b.ppy.sh/preview/{BeatmapSet.OnlineBeatmapSetID}.mp3") { OnLoadComplete = d => @@ -152,6 +154,7 @@ namespace osu.Game.Overlays.Direct Preview = (d as TrackLoader)?.Preview; Playing.TriggerChange(); + loading = false; }, })); } From 3644fa46be502683b7a0f16e81c52d234bbccd72 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Sat, 14 Oct 2017 10:53:39 +0900 Subject: [PATCH 2/2] Make sure the loading overlay is hidden when preview is user cancelled --- osu.Game/Overlays/Direct/PlayButton.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/osu.Game/Overlays/Direct/PlayButton.cs b/osu.Game/Overlays/Direct/PlayButton.cs index e222b8edb8..9317bc06cf 100644 --- a/osu.Game/Overlays/Direct/PlayButton.cs +++ b/osu.Game/Overlays/Direct/PlayButton.cs @@ -134,6 +134,7 @@ namespace osu.Game.Overlays.Direct else { Preview?.Stop(); + loading = false; } }