From 9637326f0c8be64912660890f59f3175a68b908a Mon Sep 17 00:00:00 2001
From: ekrctb <ekrctb@gmail.com>
Date: Wed, 8 Sep 2021 15:50:19 +0900
Subject: [PATCH 1/2] Allow customizing link style by override in
 `LinkFlowContainer`

---
 .../Graphics/Containers/LinkFlowContainer.cs  | 30 ++++++++++---------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/osu.Game/Graphics/Containers/LinkFlowContainer.cs b/osu.Game/Graphics/Containers/LinkFlowContainer.cs
index 85ef779e48..21c1d70d45 100644
--- a/osu.Game/Graphics/Containers/LinkFlowContainer.cs
+++ b/osu.Game/Graphics/Containers/LinkFlowContainer.cs
@@ -87,23 +87,25 @@ namespace osu.Game.Graphics.Containers
 
         private void createLink(IEnumerable<Drawable> drawables, LinkDetails link, string tooltipText, Action action = null)
         {
-            AddInternal(new DrawableLinkCompiler(drawables.OfType<SpriteText>().ToList())
+            var linkCompiler = CreateLinkCompiler(drawables.OfType<SpriteText>());
+            linkCompiler.RelativeSizeAxes = Axes.Both;
+            linkCompiler.TooltipText = tooltipText;
+            linkCompiler.Action = () =>
             {
-                RelativeSizeAxes = Axes.Both,
-                TooltipText = tooltipText,
-                Action = () =>
-                {
-                    if (action != null)
-                        action();
-                    else if (game != null)
-                        game.HandleLink(link);
-                    // fallback to handle cases where OsuGame is not available, ie. tournament client.
-                    else if (link.Action == LinkAction.External)
-                        host.OpenUrlExternally(link.Argument);
-                },
-            });
+                if (action != null)
+                    action();
+                else if (game != null)
+                    game.HandleLink(link);
+                // fallback to handle cases where OsuGame is not available, ie. tournament client.
+                else if (link.Action == LinkAction.External)
+                    host.OpenUrlExternally(link.Argument);
+            };
+
+            AddInternal(linkCompiler);
         }
 
+        protected virtual DrawableLinkCompiler CreateLinkCompiler(IEnumerable<SpriteText> parts) => new DrawableLinkCompiler(parts);
+
         // We want the compilers to always be visible no matter where they are, so RelativeSizeAxes is used.
         // However due to https://github.com/ppy/osu-framework/issues/2073, it's possible for the compilers to be relative size in the flow's auto-size axes - an unsupported operation.
         // Since the compilers don't display any content and don't affect the layout, it's simplest to exclude them from the flow.

From d417f03a39d22f7e5b39a31735659fb531f354be Mon Sep 17 00:00:00 2001
From: ekrctb <ekrctb@gmail.com>
Date: Wed, 8 Sep 2021 15:52:01 +0900
Subject: [PATCH 2/2] Simplify link style customization code

---
 .../Overlays/Changelog/ChangelogSupporterPromo.cs   | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/osu.Game/Overlays/Changelog/ChangelogSupporterPromo.cs b/osu.Game/Overlays/Changelog/ChangelogSupporterPromo.cs
index 689a7bb4a3..c2b855a0f8 100644
--- a/osu.Game/Overlays/Changelog/ChangelogSupporterPromo.cs
+++ b/osu.Game/Overlays/Changelog/ChangelogSupporterPromo.cs
@@ -126,7 +126,7 @@ namespace osu.Game.Overlays.Changelog
             };
 
             supportLinkText.AddText("Support further development of osu! and ");
-            supportLinkText.AddLink("become an osu!supporter", "https://osu.ppy.sh/home/support", t => t.Font = t.Font.With(weight: FontWeight.Bold));
+            supportLinkText.AddLink("become an osu!supporter", @"https://osu.ppy.sh/home/support", t => t.Font = t.Font.With(weight: FontWeight.Bold));
             supportLinkText.AddText(" today!");
 
             imageContainer.Children = new Drawable[]
@@ -170,27 +170,18 @@ namespace osu.Game.Overlays.Changelog
             {
             }
 
-            public new void AddLink(string text, string url, Action<SpriteText> creationParameters) =>
-                AddInternal(new SupporterPromoLinkCompiler(AddText(text, creationParameters)) { Url = url });
+            protected override DrawableLinkCompiler CreateLinkCompiler(IEnumerable<SpriteText> parts) => new SupporterPromoLinkCompiler(parts);
 
             private class SupporterPromoLinkCompiler : DrawableLinkCompiler
             {
-                [Resolved(CanBeNull = true)]
-                private OsuGame game { get; set; }
-
-                public string Url;
-
                 public SupporterPromoLinkCompiler(IEnumerable<Drawable> parts)
                     : base(parts)
                 {
-                    RelativeSizeAxes = Axes.Both;
                 }
 
                 [BackgroundDependencyLoader]
                 private void load(OsuColour colour)
                 {
-                    TooltipText = Url;
-                    Action = () => game?.HandleLink(Url);
                     IdleColour = colour.PinkDark;
                     HoverColour = Color4.White;
                 }