h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 15:33:21 +08:00
Code Issues Releases Wiki Activity

Make incoming Channel target non-nullable

Browse Source
This commit is contained in:
Dean Herbert 2022-11-30 14:30:20 +09:00
parent 69bf0df179
commit b5c514a8f0
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game.Tests/Visual/Online/TestSceneNowPlayingCommand.cs
View File

@ -34,7 +34,7 @@ namespace osu.Game.Tests.Visual.Online
{ {
AddStep("Set activity", () => api.Activity.Value = new UserActivity.InLobby(null)); AddStep("Set activity", () => api.Activity.Value = new UserActivity.InLobby(null));
AddStep("Run command", () => Add(new NowPlayingCommand())); AddStep("Run command", () => Add(new NowPlayingCommand(new Channel())));
AddAssert("Check correct response", () => postTarget.LastMessage.Contains("is listening")); AddAssert("Check correct response", () => postTarget.LastMessage.Contains("is listening"));
} }
@ -44,7 +44,7 @@ namespace osu.Game.Tests.Visual.Online
{ {
AddStep("Set activity", () => api.Activity.Value = new UserActivity.Editing(new BeatmapInfo())); AddStep("Set activity", () => api.Activity.Value = new UserActivity.Editing(new BeatmapInfo()));
AddStep("Run command", () => Add(new NowPlayingCommand())); AddStep("Run command", () => Add(new NowPlayingCommand(new Channel())));
AddAssert("Check correct response", () => postTarget.LastMessage.Contains("is editing")); AddAssert("Check correct response", () => postTarget.LastMessage.Contains("is editing"));
} }
@ -54,7 +54,7 @@ namespace osu.Game.Tests.Visual.Online
{ {
AddStep("Set activity", () => api.Activity.Value = new UserActivity.InSoloGame(new BeatmapInfo(), new RulesetInfo())); AddStep("Set activity", () => api.Activity.Value = new UserActivity.InSoloGame(new BeatmapInfo(), new RulesetInfo()));
AddStep("Run command", () => Add(new NowPlayingCommand())); AddStep("Run command", () => Add(new NowPlayingCommand(new Channel())));
AddAssert("Check correct response", () => postTarget.LastMessage.Contains("is playing")); AddAssert("Check correct response", () => postTarget.LastMessage.Contains("is playing"));
} }
@ -70,7 +70,7 @@ namespace osu.Game.Tests.Visual.Online
BeatmapInfo = { OnlineID = hasOnlineId ? 1234 : -1 } BeatmapInfo = { OnlineID = hasOnlineId ? 1234 : -1 }
}); });
AddStep("Run command", () => Add(new NowPlayingCommand())); AddStep("Run command", () => Add(new NowPlayingCommand(new Channel())));
if (hasOnlineId) if (hasOnlineId)
AddAssert("Check link presence", () => postTarget.LastMessage.Contains("/b/1234")); AddAssert("Check link presence", () => postTarget.LastMessage.Contains("/b/1234"));
@ -85,7 +85,7 @@ namespace osu.Game.Tests.Visual.Online
AddStep("Add Hidden mod", () => SelectedMods.Value = new[] { Ruleset.Value.CreateInstance().CreateMod<ModHidden>() }); AddStep("Add Hidden mod", () => SelectedMods.Value = new[] { Ruleset.Value.CreateInstance().CreateMod<ModHidden>() });
AddStep("Run command", () => Add(new NowPlayingCommand())); AddStep("Run command", () => Add(new NowPlayingCommand(new Channel())));
AddAssert("Check mod is present", () => postTarget.LastMessage.Contains("+HD")); AddAssert("Check mod is present", () => postTarget.LastMessage.Contains("+HD"));
} }

2
osu.Game/Online/Chat/NowPlayingCommand.cs
View File

@ -38,7 +38,7 @@ namespace osu.Game.Online.Chat
/// Creates a new <see cref="NowPlayingCommand"/> to post the currently-playing beatmap to a parenting <see cref="IChannelPostTarget"/>. /// Creates a new <see cref="NowPlayingCommand"/> to post the currently-playing beatmap to a parenting <see cref="IChannelPostTarget"/>.
/// </summary> /// </summary>
/// <param name="target">The target channel to post to. If <c>null</c>, the currently-selected channel will be posted to.</param> /// <param name="target">The target channel to post to. If <c>null</c>, the currently-selected channel will be posted to.</param>
public NowPlayingCommand(Channel? target = null) public NowPlayingCommand(Channel target)
{ {
this.target = target; this.target = target;
} }