Merge branch 'master' into editor-clock

osu-framework

@@ -1 +1 @@
-Subproject commit e4b0b57f5d3a80c09dcdfb6c8d30962e842b9fc3
+Subproject commit 02d7a0fa4798d197cd08570ee48951edbb7c7860

osu.Game/Online/API/APIAccess.cs

@@ -37,13 +37,7 @@ namespace osu.Game.Online.API
 
         public Bindable<User> LocalUser { get; } = new Bindable<User>(createGuestUser());
 
-        public string Token
-        {
-            get { return authentication.Token?.ToString(); }
-            set { authentication.Token = string.IsNullOrEmpty(value) ? null : OAuthToken.Parse(value); }
-        }
-
-        protected bool HasLogin => Token != null || !string.IsNullOrEmpty(ProvidedUsername) && !string.IsNullOrEmpty(password);
+        protected bool HasLogin => authentication.Token.Value != null || !string.IsNullOrEmpty(ProvidedUsername) && !string.IsNullOrEmpty(password);
 
         private readonly CancellationTokenSource cancellationToken = new CancellationTokenSource();
 
@@ -57,11 +51,15 @@ namespace osu.Game.Online.API
             log = Logger.GetLogger(LoggingTarget.Network);
 
             ProvidedUsername = config.Get<string>(OsuSetting.Username);
-            Token = config.Get<string>(OsuSetting.Token);
+
+            authentication.TokenString = config.Get<string>(OsuSetting.Token);
+            authentication.Token.ValueChanged += onTokenChanged;
 
             Task.Factory.StartNew(run, cancellationToken.Token, TaskCreationOptions.LongRunning, TaskScheduler.Default);
         }
 
+        private void onTokenChanged(OAuthToken token) => config.Set(OsuSetting.Token, config.Get<bool>(OsuSetting.SavePassword) ? authentication.TokenString : string.Empty);
+
         private readonly List<IOnlineComponent> components = new List<IOnlineComponent>();
 
         internal new void Schedule(Action action) => base.Schedule(action);
@@ -306,9 +304,6 @@ namespace osu.Game.Online.API
         {
             base.Dispose(isDisposing);
 
-            config.Set(OsuSetting.Token, config.Get<bool>(OsuSetting.SavePassword) ? Token : string.Empty);
-            config.Save();
-
             flushQueue();
             cancellationToken.Cancel();
         }

osu.Game/Online/API/OAuth.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
 
 using System.Diagnostics;
+using osu.Framework.Configuration;
 using osu.Framework.IO.Network;
 
 namespace osu.Game.Online.API
@@ -12,7 +13,13 @@ namespace osu.Game.Online.API
         private readonly string clientSecret;
         private readonly string endpoint;
 
-        public OAuthToken Token;
+        public readonly Bindable<OAuthToken> Token = new Bindable<OAuthToken>();
+
+        public string TokenString
+        {
+            get => Token.Value?.ToString();
+            set => Token.Value = string.IsNullOrEmpty(value) ? null : OAuthToken.Parse(value);
+        }
 
         internal OAuth(string clientId, string clientSecret, string endpoint)
         {
@@ -47,7 +54,7 @@ namespace osu.Game.Online.API
                     return false;
                 }
 
-                Token = req.ResponseObject;
+                Token.Value = req.ResponseObject;
                 return true;
             }
         }
@@ -66,14 +73,14 @@ namespace osu.Game.Online.API
                 {
                     req.Perform();
 
-                    Token = req.ResponseObject;
+                    Token.Value = req.ResponseObject;
                     return true;
                 }
             }
             catch
             {
                 //todo: potentially only kill the refresh token on certain exception types.
-                Token = null;
+                Token.Value = null;
                 return false;
             }
         }
@@ -95,15 +102,15 @@ namespace osu.Game.Online.API
                 if (accessTokenValid) return true;
 
                 // if not, let's try using our refresh token to request a new access token.
-                if (!string.IsNullOrEmpty(Token?.RefreshToken))
+                if (!string.IsNullOrEmpty(Token.Value?.RefreshToken))
                     // ReSharper disable once PossibleNullReferenceException
-                    AuthenticateWithRefresh(Token.RefreshToken);
+                    AuthenticateWithRefresh(Token.Value.RefreshToken);
 
                 return accessTokenValid;
             }
         }
 
-        private bool accessTokenValid => Token?.IsValid ?? false;
+        private bool accessTokenValid => Token.Value?.IsValid ?? false;
 
         internal bool HasValidAccessToken => RequestAccessToken() != null;
 
@@ -111,12 +118,12 @@ namespace osu.Game.Online.API
         {
             if (!ensureAccessToken()) return null;
 
-            return Token.AccessToken;
+            return Token.Value.AccessToken;
         }
 
         internal void Clear()
         {
-            Token = null;
+            Token.Value = null;
         }
 
         private class AccessTokenRequestRefresh : AccessTokenRequest

osu.Game/OsuGame.cs

@@ -36,6 +36,10 @@ using osu.Game.Overlays.Volume;
 
 namespace osu.Game
 {
+    /// <summary>
+    /// The full osu! experience. Builds on top of <see cref="OsuGameBase"/> to add menus and binding logic
+    /// for initial components that are generally retrieved via DI.
+    /// </summary>
     public class OsuGame : OsuGameBase, IKeyBindingHandler<GlobalAction>
     {
         public Toolbar Toolbar;

osu.Game/OsuGameBase.cs

@@ -34,6 +34,11 @@ using osu.Game.Skinning;
 
 namespace osu.Game
 {
+    /// <summary>
+    /// The most basic <see cref="Game"/> that can be used to host osu! components and systems.
+    /// Unlike <see cref="OsuGame"/>, this class will not load any kind of UI, allowing it to be used
+    /// for provide dependencies to test cases without interfering with them.
+    /// </summary>
     public class OsuGameBase : Framework.Game, ICanAcceptFiles
     {
         protected OsuConfigManager LocalConfig;