h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 00:33:21 +08:00
Code Issues Releases Wiki Activity

Do not attempt to stop watching user presence when requested to disconnect

Browse Source 
First of all, this sort of cleanup isn't really the client's
responsibility, and secondly, at the point the client received this
request to disconnect, *none of its requests will be honored anymore*
(currently the only scenario of this if another client has connected
- the server-side concurrency filter will reject this request).

When disconnection is requested, the only valid thing to do with respect
to talking to the server is to stop doing it.

This will be moved server-side in a follow-up change, although I'm not
even strictly sure that's required - I'd like to think signalr would
know to clean up a disconnecting client from all groups they were in.
This commit is contained in:
Bartłomiej Dach 2024-02-16 12:59:22 +01:00
parent 9fa60b169e
commit b4aa247032
No known key found for this signature in database
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game/Online/Metadata/OnlineMetadataClient.cs
View File

@ -232,7 +232,6 @@ namespace osu.Game.Online.Metadata
public override async Task DisconnectRequested() public override async Task DisconnectRequested()
{ {
await base.DisconnectRequested().ConfigureAwait(false); await base.DisconnectRequested().ConfigureAwait(false);
await EndWatchingUserPresence().ConfigureAwait(false);
if (connector != null) if (connector != null)
await connector.Disconnect().ConfigureAwait(false); await connector.Disconnect().ConfigureAwait(false);
} }