h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:52:53 +08:00
Code Issues Releases Wiki Activity

Check realm file can be written to before attempting further initialisation

Browse Source 
Rather than creating a "corrupt" realm file in such cases, the game will
now refuse to start. This behaviour is usually what we want. In most
cases a second click on the game will start it successfully (the
previous instance's file handles are still doing stuff, or windows
defender is being silly).

Closes https://github.com/ppy/osu/issues/28018.
This commit is contained in:
Dean Herbert 2024-04-28 19:07:39 +08:00
parent 134ab6d45a
commit b262497083
No known key found for this signature in database
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Database/RealmAccess.cs
View File

@ -300,6 +300,21 @@ namespace osu.Game.Database
private Realm prepareFirstRealmAccess() private Realm prepareFirstRealmAccess()
{ {
// Before attempting to initialise realm, make sure the realm file isn't locked and has correct permissions.
//
// This is to avoid failures like:
// Realms.Exceptions.RealmException: SetEndOfFile() failed: unknown error (1224)
//
// which can occur due to file handles still being open by a previous instance.
if (storage.Exists(Filename))
{
// If this fails we allow it to block game startup.
// It's better than any alternative we can offer.
using (var _ = storage.GetStream(Filename, FileAccess.ReadWrite))
{
}
}
string newerVersionFilename = $"{Filename.Replace(realm_extension, string.Empty)}_newer_version{realm_extension}"; string newerVersionFilename = $"{Filename.Replace(realm_extension, string.Empty)}_newer_version{realm_extension}";
// Attempt to recover a newer database version if available. // Attempt to recover a newer database version if available.
@ -321,7 +336,7 @@ namespace osu.Game.Database
{ {
Logger.Error(e, "Your local database is too new to work with this version of osu!. Please close osu! and install the latest release to recover your data."); Logger.Error(e, "Your local database is too new to work with this version of osu!. Please close osu! and install the latest release to recover your data.");
// If a newer version database already exists, don't backup again. We can presume that the first backup is the one we care about. // If a newer version database already exists, don't create another backup. We can presume that the first backup is the one we care about.
if (!storage.Exists(newerVersionFilename)) if (!storage.Exists(newerVersionFilename))
createBackup(newerVersionFilename); createBackup(newerVersionFilename);
} }