h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-07 20:47:26 +08:00
Code Issues Releases Wiki Activity

Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed

Browse Source
This commit is contained in:
Dean Herbert 2023-03-31 02:30:04 +09:00
parent 4dd0c2c7a5
commit b25a59fd14
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Screens/Play/Player.cs
View File

@ -358,10 +358,10 @@ namespace osu.Game.Screens.Play
ScoreProcessor.RevertResult(r); ScoreProcessor.RevertResult(r);
}; };
DimmableStoryboard.HasStoryboardEnded.ValueChanged += _ => scoreCompleted(); DimmableStoryboard.HasStoryboardEnded.ValueChanged += _ => checkScoreCompleted();
// Bind the judgement processors to ourselves // Bind the judgement processors to ourselves
ScoreProcessor.HasCompleted.BindValueChanged(_ => scoreCompleted()); ScoreProcessor.HasCompleted.BindValueChanged(_ => checkScoreCompleted());
HealthProcessor.Failed += onFail; HealthProcessor.Failed += onFail;
// Provide judgement processors to mods after they're loaded so that they're on the gameplay clock, // Provide judgement processors to mods after they're loaded so that they're on the gameplay clock,
@ -702,7 +702,7 @@ namespace osu.Game.Screens.Play
/// <summary> /// <summary>
/// Handles changes in player state which may progress the completion of gameplay / this screen's lifetime. /// Handles changes in player state which may progress the completion of gameplay / this screen's lifetime.
/// </summary> /// </summary>
private void scoreCompleted() private void checkScoreCompleted()
{ {
// If this player instance is in the middle of an exit, don't attempt any kind of state update. // If this player instance is in the middle of an exit, don't attempt any kind of state update.
if (!this.IsCurrentScreen()) if (!this.IsCurrentScreen())