Update the pauseLoop sample instantly on skin change

osu.Game/Screens/Play/PauseOverlay.cs

@@ -28,6 +28,7 @@ namespace osu.Game.Screens.Play
 
         private SkinnableSound pauseLoop;
 
+        public void FlushPendingSkinChanges() => pauseLoop.FlushPendingSkinChanges();
         protected override Action BackAction => () => InternalButtons.First().TriggerClick();
 
         [BackgroundDependencyLoader]

osu.Game/Screens/Play/Player.cs

@@ -316,6 +316,11 @@ namespace osu.Game.Screens.Play
             // we may want to limit this in the future to disallow rulesets from outright replacing elements the user expects to be there.
             failAnimationLayer.Add(createOverlayComponents(Beatmap.Value));
 
+            rulesetSkinProvider.SourceChanged += () =>
+            {
+                PauseOverlay.FlushPendingSkinChanges();
+            };
+
             if (!DrawableRuleset.AllowGameplayOverlays)
             {
                 HUDOverlay.ShowHud.Value = false;

osu.Game/Skinning/SkinReloadableDrawable.cs

@@ -42,7 +42,7 @@ namespace osu.Game.Skinning
             pendingSkinChange = Scheduler.Add(skinChanged);
         }
 
-        public void FlushPendingSkinChanges()
+        public virtual void FlushPendingSkinChanges()
         {
             if (pendingSkinChange == null)
                 return;

osu.Game/Skinning/SkinnableSound.cs

@@ -110,6 +110,13 @@ namespace osu.Game.Skinning
             }
         }
 
+        public override void FlushPendingSkinChanges()
+        {
+            base.FlushPendingSkinChanges();
+
+            samplesContainer.ForEach(c => c.FlushPendingSkinChanges());
+        }
+
         /// <summary>
         /// Plays the samples.
         /// </summary>
@@ -119,8 +126,6 @@ namespace osu.Game.Skinning
 
             samplesContainer.ForEach(c =>
             {
-                c.FlushPendingSkinChanges();
-
                 if (PlayWhenZeroVolume || c.AggregateVolume.Value > 0)
                 {
                     c.Stop();