h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 07:33:20 +08:00
Code Issues Releases Wiki Activity

Remove ISliderDrawingSettingsProvider

Browse Source 
Seems like excessive abstraction.
This commit is contained in:
Bartłomiej Dach 2023-11-20 13:02:51 +09:00
parent 831884a64b
commit affef85f25
No known key found for this signature in database
4 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderPlacementBlueprint.cs
View File

@ -46,7 +46,7 @@ namespace osu.Game.Rulesets.Osu.Edit.Blueprints.Sliders
private IDistanceSnapProvider distanceSnapProvider { get; set; }
[Resolved(CanBeNull = true)]
private ISliderDrawingSettingsProvider drawingSettingsProvider { get; set; }
private OsuSliderDrawingSettingsProvider drawingSettingsProvider { get; set; }
private readonly IncrementalBSplineBuilder bSplineBuilder = new IncrementalBSplineBuilder();

13
osu.Game.Rulesets.Osu/Edit/ISliderDrawingSettingsProvider.cs
View File

@ -1,13 +0,0 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using osu.Framework.Bindables;
namespace osu.Game.Rulesets.Osu.Edit
{
public interface ISliderDrawingSettingsProvider
{
BindableFloat Tolerance { get; }
BindableFloat CornerThreshold { get; }
}
}

2
osu.Game.Rulesets.Osu/Edit/OsuHitObjectComposer.cs
View File

@ -63,7 +63,7 @@ namespace osu.Game.Rulesets.Osu.Edit
[Cached(typeof(IDistanceSnapProvider))]
protected readonly OsuDistanceSnapProvider DistanceSnapProvider = new OsuDistanceSnapProvider();
[Cached(typeof(ISliderDrawingSettingsProvider))]
[Cached]
protected readonly OsuSliderDrawingSettingsProvider SliderDrawingSettingsProvider = new OsuSliderDrawingSettingsProvider();
[BackgroundDependencyLoader]

2
osu.Game.Rulesets.Osu/Edit/OsuSliderDrawingSettingsProvider.cs
View File

@ -10,7 +10,7 @@ using osu.Game.Rulesets.Edit;
namespace osu.Game.Rulesets.Osu.Edit
{
public partial class OsuSliderDrawingSettingsProvider : Drawable, ISliderDrawingSettingsProvider, IToolboxAttachment
public partial class OsuSliderDrawingSettingsProvider : Drawable, IToolboxAttachment
{
public BindableFloat Tolerance { get; } = new BindableFloat(1.5f)
{