h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-26 18:03:11 +08:00
Code Issues Releases Wiki Activity

Trim redundant comments

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-11-02 08:18:37 +01:00
parent c2de03aa44
commit ad82ada030
No known key found for this signature in database
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinner.cs
View File

@ -277,17 +277,13 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
spinningSample.Frequency.Value = spinning_sample_modulated_base_frequency + Progress; spinningSample.Frequency.Value = spinning_sample_modulated_base_frequency + Progress;
// Ticks can theoretically be judged at any point in the spinner's duration. // Ticks can theoretically be judged at any point in the spinner's duration.
// For performance reasons, we only want to keep the next tick alive. // A tick must be alive to correctly play back samples,
// but for performance reasons, we only want to keep the next tick alive.
var next = NestedHitObjects.FirstOrDefault(h => !h.Judged); var next = NestedHitObjects.FirstOrDefault(h => !h.Judged);
// See default `LifetimeStart` as set in `DrawableSpinnerTick`. // See default `LifetimeStart` as set in `DrawableSpinnerTick`.
if (next?.LifetimeStart == double.MaxValue) if (next?.LifetimeStart == double.MaxValue)
{
// the tick can be theoretically judged at any point in the spinner's duration,
// so it must be alive throughout the spinner's entire lifetime.
// this mostly matters for correct sample playback.
next.LifetimeStart = HitObject.StartTime; next.LifetimeStart = HitObject.StartTime;
}
} }
protected override void UpdateAfterChildren() protected override void UpdateAfterChildren()