h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 23:12:56 +08:00
Code Issues Releases Wiki Activity

Expand test coverage

Browse Source 
- Covers fail case that wasn't covered before
- Removes arbitrary wait step that was inevitably going to cause
  intermittent test failures
This commit is contained in:
Bartłomiej Dach 2024-06-28 09:30:28 +02:00
parent b36e0f0875
commit ace6427d40
No known key found for this signature in database
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game.Tests/Visual/Editing/TestSceneEditorTestGameplay.cs
View File

@ -126,10 +126,11 @@ namespace osu.Game.Tests.Visual.Editing
AddAssert("sample playback re-enabled", () => !Editor.SamplePlaybackDisabled.Value); AddAssert("sample playback re-enabled", () => !Editor.SamplePlaybackDisabled.Value);
} }
[Test] [TestCase(2000)] // chosen to be after last object in the map
public void TestGameplayTestAtEndOfBeatmap() [TestCase(22000)] // chosen to be in the middle of the last spinner
public void TestGameplayTestAtEndOfBeatmap(int offsetFromEnd)
{ {
AddStep("seek to last 2 seconds", () => EditorClock.Seek(importedBeatmapSet.MaxLength - 2000)); AddStep($"seek to end minus {offsetFromEnd}ms", () => EditorClock.Seek(importedBeatmapSet.MaxLength - offsetFromEnd));
AddStep("click test gameplay button", () => AddStep("click test gameplay button", () =>
{ {
var button = Editor.ChildrenOfType<TestGameplayButton>().Single(); var button = Editor.ChildrenOfType<TestGameplayButton>().Single();
@ -140,8 +141,7 @@ namespace osu.Game.Tests.Visual.Editing
AddUntilStep("player pushed", () => Stack.CurrentScreen is EditorPlayer); AddUntilStep("player pushed", () => Stack.CurrentScreen is EditorPlayer);
AddWaitStep("wait some", 5); AddUntilStep("current screen is editor", () => Stack.CurrentScreen is Editor);
AddAssert("current screen is editor", () => Stack.CurrentScreen is Editor);
} }
[Test] [Test]