h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-06 04:13:11 +08:00
Code Issues Releases Wiki Activity

Make notifications less noisy

Browse Source
This commit is contained in:
Dean Herbert 2018-07-13 21:25:08 +09:00
parent d08c44a726
commit ac4f25c5bc
4 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Desktop/Overlays/VersionManager.cs
View File

@ -111,6 +111,8 @@ namespace osu.Desktop.Overlays
private class UpdateCompleteNotification : SimpleNotification private class UpdateCompleteNotification : SimpleNotification
{ {
public override bool IsImportant => true;
public UpdateCompleteNotification(string version, Action<string> openUrl = null) public UpdateCompleteNotification(string version, Action<string> openUrl = null)
{ {
Text = $"You are now running osu!lazer {version}.\nClick to see what's new!"; Text = $"You are now running osu!lazer {version}.\nClick to see what's new!";

7
osu.Game/Database/ArchiveModelManager.cs
View File

@ -116,7 +116,7 @@ namespace osu.Game.Database
/// <param name="paths">One or more archive locations on disk.</param> /// <param name="paths">One or more archive locations on disk.</param>
public void Import(params string[] paths) public void Import(params string[] paths)
{ {
var notification = new ProgressNotification var notification = new ImportNotification
{ {
Text = "Import is initialising...", Text = "Import is initialising...",
Progress = 0, Progress = 0,
@ -407,5 +407,10 @@ namespace osu.Game.Database
return new LegacyFilesystemReader(path); return new LegacyFilesystemReader(path);
throw new InvalidFormatException($"{path} is not a valid archive"); throw new InvalidFormatException($"{path} is not a valid archive");
} }
private class ImportNotification : ProgressNotification
{
public override bool IsImportant => true;
}
} }
} }

3
osu.Game/Overlays/NotificationOverlay.cs
View File

@ -128,7 +128,8 @@ namespace osu.Game.Overlays
var section = sections.Children.FirstOrDefault(s => s.AcceptTypes.Any(accept => accept.IsAssignableFrom(ourType))); var section = sections.Children.FirstOrDefault(s => s.AcceptTypes.Any(accept => accept.IsAssignableFrom(ourType)));
section?.Add(notification, notification.DisplayOnTop ? -runningDepth : runningDepth); section?.Add(notification, notification.DisplayOnTop ? -runningDepth : runningDepth);
State = Visibility.Visible; if (notification.IsImportant)
State = Visibility.Visible;
updateCounts(); updateCounts();
}); });

5
osu.Game/Overlays/Notifications/Notification.cs
View File

@ -23,6 +23,11 @@ namespace osu.Game.Overlays.Notifications
/// </summary> /// </summary>
public event Action Closed; public event Action Closed;
/// <summary>
/// Whether this notification should forcefully display itself.
/// </summary>
public virtual bool IsImportant => false;
/// <summary> /// <summary>
/// Run on user activating the notification. Return true to close. /// Run on user activating the notification. Return true to close.
/// </summary> /// </summary>