From ab28948744f0114e5053d3b0321f0e37990db7c1 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Tue, 2 Nov 2021 13:17:21 +0900 Subject: [PATCH] Default legacy decoder to `General` section, rather than none This is mainly to reach parity with how stable handles such cases for skins specifically. It was brought to our attention after finding a skin with a malformed `\[General]` tag which did not break further parsing of the file on stable, but did on lazer. Note that stable defaults to an "unknown" section for beatmaps, but functionally I can't think of a regression case from changing this to a "general" default. --- osu.Game/Beatmaps/Formats/LegacyDecoder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Beatmaps/Formats/LegacyDecoder.cs b/osu.Game/Beatmaps/Formats/LegacyDecoder.cs index 56525ddb14..f17366a1b3 100644 --- a/osu.Game/Beatmaps/Formats/LegacyDecoder.cs +++ b/osu.Game/Beatmaps/Formats/LegacyDecoder.cs @@ -27,7 +27,7 @@ namespace osu.Game.Beatmaps.Formats protected override void ParseStreamInto(LineBufferedReader stream, T output) { - Section section = Section.None; + Section section = Section.General; string line;